Manchester | 26-ITP-Sep | Precious Moses | Sprint 1 | FormatAs12HourClock by moses77-boop · Pull Request #1637 · CodeYourFuture/Module-Structuring-and-Testing-Data

moses77-boop · 2026-10-03T14:12:37Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1197

Changelist

This PR contains fixes and tests with edge-cases.

… and period handling

…arity

…urate time formatting

…ases

cjyuan · 2026-10-04T17:10:06Z

+// function formatAs12HourClock(time) {

-  const hours = Number(time.slice(0, 2));
+//   const hours = Number(time.slice(0, 2));

-  if (hours > 12) {
-    return `${hours - 12}:00 pm`;
+//   if (hours > 12) {
+//     return `${hours - 12}:00 pm`;
+//   }
+//   return `${time} am`;
+// }
+
+// export {formatAs12HourClock};


Unused code should be removed to keep the codebase clean.

cjyuan · 2026-10-04T17:12:57Z

+  return `${displayHour}:${minutePart}${period}`;
+}
 export {formatAs12HourClock};
+console.log(formatAs12HourClock("08:40"))


Code submitted in a PR should also be free of debugging code.

Thanks for the feedback!
Fixed

cjyuan · 2026-10-04T17:18:23Z

+  if(hours < 12){
+    period = "am";
+  } else {


The spacing before { is not fully consistent.

Suggestion:

Look up the benefits of using a code formatter.

Install the Prettier extension for VS Code, then:

Use VS Code's Format Document feature to format your code.

Optionally, enable Format On Save and Format On Paste to keep your code consistently formatted.

Resource: Visual Studio Code - Formatting

Note: The formatter may not work correctly if your code contains syntax errors.

Thanks for your feedback.

I don't paste codes. I have Prettier extension installed already, not sure why it's not auto formatting, but I'll be happy to have a look and see how to configure it.

Fixed now! 👍

cjyuan

This branch should only contain modified files in the format-clock-edge-cases folder.

Some of your recent commits have modified files in some other folders. Could you revert the changes made in those folders?

Note: Don't forget to add the "Needs review" label back to a PR whenever it is ready to be re-reviewed.

cjyuan · 2026-10-04T22:24:29Z

+  let period;
+  if(hours < 12){
+    period = "am";
+  }else{
+    period = "pm";
  }


Could practice using the ? : operator to simplify the code on line 5-10 into one line of code.

Thanks for the feedback!

Code refactored.

cjyuan · 2026-10-04T22:25:47Z

+  let displayHour = hours % 12;
+  if(displayHour === 0){
+    displayHour = 12;
+  } 


Code on lines 12-15 could also be simplified.

Thanks for the feedback!

Code refactored.

cjyuan · 2026-10-04T22:31:17Z

@@ -1,11 +1,18 @@
-function formatAs12HourClock(time) {
+function formatAs12HourClock(time){


Check out this coding style article about common format convention.

The current formatting is consistent but it doesn't look like the work of Prettier.

Above attached is a screenshot of my VS Code panel, showing Prettier, and other CYF approved extensions. If it needs further assessment I'd be glad to book a session with you to work me through on how to reconfigure Prettier in my VS Code.

…ncies

cjyuan · 2026-10-05T10:33:48Z

Changes are good. Well done!

moses77-boop added 19 commits October 3, 2026 10:16

refactor: update formatAs12HourClock function to improve time parsing…

c3cc796

… and period handling

refactor: update test syntax to use arrow functions for consistency

b03e0fb

fix: ensure formatAs12HourClock function exports correctly

05e8ef3

test: add test case for converting midnight time

1544b38

refactor: improve time conversion logic and enhance test cases for cl…

8230a0e

…arity

fix: correct return statement in formatAs12HourClock function for acc…

ead95df

…urate time formatting

test: add test case for converting the last minute before noon

19e10f5

test: add test case for converting exact noon to pm

15938a2

test: add test case for converting time just after noon

8acdeaa

fix: add missing newline at end of timeConverter.test.js

a7d1115

fix: remove space before am/pm in time formatting and clean up test c…

ee8f85b

…ases

fix: remove space before period in time formatting

f93cd35

test: add test case for converting late evening hour

59863c5

test: add test case for converting last minute of the day

c6ed571

fix: correct expected output for first afternoon hour test case

ced1c53

test: add test case for preserving minutes with leading zero

9f0876f

test: update console log to test formatting for 8:00 AM

03c860b

test: add test case for preserving non-zero minutes

42d563c

test: update console log to test formatting for 8:40 AM

91ccb0c

This comment has been minimized.

Sign in to view

moses77-boop added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 3, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 3, 2026

moses77-boop added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module labels Oct 3, 2026

cjyuan reviewed Oct 4, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 4, 2026

moses77-boop added 2 commits October 4, 2026 20:15

Remove commented-out code from time formatting function

472364d

Remove console log from time formatting function

5b48a96

moses77-boop added 2 commits October 4, 2026 20:26

Add jsconfig.json for TypeScript configuration

8a74015

Format code and improve readability

27919c8

cjyuan reviewed Oct 4, 2026

View reviewed changes

moses77-boop added 2 commits October 5, 2026 01:24

Simplify period determination and improve formatting

fa688b1

Refactor display hour calculation for 12-hour clock format

5d58269

moses77-boop added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 5, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 5, 2026

This comment has been minimized.

Sign in to view

moses77-boop added 2 commits October 5, 2026 02:03

Remove jsconfig.json and clean up package.json by deleting devDepende…

f9fac2a

…ncies

Refactor folders to match main

aba0771

moses77-boop added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 5, 2026

		@@ -1,11 +1,18 @@
		function formatAs12HourClock(time) {
		function formatAs12HourClock(time){

Uh oh!

Conversation

moses77-boop commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task code

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

moses77-boop Oct 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

moses77-boop Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

moses77-boop Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

cjyuan commented Oct 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

moses77-boop commented Oct 3, 2026 •

edited

Loading

moses77-boop Oct 4, 2026 •

edited

Loading

cjyuan left a comment •

edited

Loading

moses77-boop Oct 5, 2026 •

edited

Loading

moses77-boop Oct 5, 2026 •

edited

Loading