Conversation
abmhts
added
the
Needs Review
abdishakoor-dev
left a comment
abdishakoor-dev
left a comment
Contributor
There was a problem hiding this comment.
All the requirements are met, and the function gives the right answer for every valid time I tried. Testing the first and last minute of the midnight and noon hours is good edge-case thinking.
Marking this Complete, well done.
abdishakoor-dev
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1197
Changelist
Fixed the real-minutes bug and added tests covering midnight, noon, and minute edge cases.