London | 26-ITP-Sep | Maharit Belai | Sprint 1 | Format clock edge cases by MaharitB · Pull Request #1645 · CodeYourFuture/Module-Structuring-and-Testing-Data

MaharitB · 2026-10-04T23:27:09Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1197

Changelist

wrote a test for clock edge cases.

Questions

…00 pm

…led.

abdishakoor-dev

Your commit history shows the process this task is about: write a test, see it fail, then fix the code. You also kept the two starter tests exactly as they were, and the function gives the right answer for every valid time I tried.

Two things before I can mark this Complete:

The midnight test uses an input that isn't in the range the README asks for. See my comment on timeConverter.test.js line 14.
One of the starter's bugs, and the edges where am changes to pm and back, have no test yet. See my comment on line 22.

The two comments on timeConverter.js are smaller and come out of the same idea: try deleting or changing a line, and see whether any test notices.

Add the Needs Review label again once you've pushed.

abdishakoor-dev · 2026-10-05T08:25:22Z

+});
+
+test("can correctly convert midnight  ", function () {
+  assert.equal(formatAs12HourClock("24:00"), "12:00 am");


On a 24-hour clock, does midnight show as 24:00 or 00:00? The clock in this task runs from 00:00 to 23:59, and the README only asks for valid inputs. Which input should this test use? Once you've changed it, do you still need lines 5 to 7 of timeConverter.js?

Fixed now, and the 24:00 check has gone too. Good.

abdishakoor-dev · 2026-10-05T08:25:23Z

+});
+
+test("can correctly convert time with minutes ", function () {
+  assert.equal(formatAs12HourClock("12:45"), "12:45 pm");


The starter dropped the minutes for afternoon times: "23:59" gave "11:00 pm". Try changing line 18 of timeConverter.js to return :00 instead of the minutes, and run your tests. Does any of them fail?

Bugs often hide at the exact point where something changes. What is the last minute before am turns into pm, and the last minute of the whole day? Each of those is worth its own test.

Your 13:01 test catches this now for 1pm to 9pm. The last gap is after 10pm, see my new comment on line 15.

abdishakoor-dev · 2026-10-05T08:25:23Z

+  if (time === "24:00") {
+    return `12:00 am`;
+  }
+  if (time === "12:00") {


If you delete lines 8 to 10, which if would "12:00" reach next? Would it still give "12:00 pm"?

That's the one, deleted and the test still passes.

abdishakoor-dev · 2026-10-05T08:25:23Z

+  if (time === "12:00") {
+    return `12:00 pm`;
+  }
+  if (stringHours == "00") {


Optional, not needed for Complete: line 14 checks hours with ===. Could line 11 check hours in the same way? If it did, would you still need stringHours on line 2?

Good question! My initial thought was to compare string to a string thinking if I compare the number to a string it will give me false. Now that I read about it, I can compare the hour with == to the "00" and get the same answer. because in Java Script if you compare numeric with string, and if the sting can be changed to numeric value, the output can be true.

So I will make amends to the code based on this finding.

Good reading, and removing stringHours made the function simpler. Nothing more needed here.

…n the program test success.

… codes .test was success.

…ith out it

…out it

… success .

…o testes failed made amend based on that

abdishakoor-dev

Good progress. Midnight and midday are both sorted, and the extra lines they needed are gone. Choosing 01:01 pm so afternoons match 08:00 am keeps the output consistent, nice.

You're very close. Two small things and this is Complete:

Add two more tests, written the same way as your others:
- "11:59" should give "11:59 am" (the last minute before am turns into pm)
- "23:59" should give "11:59 pm" (the last minute of the day)
My comment on timeConverter.js line 15 explains why the second one matters.
Both files need formatting again. Open timeConverter.js, right click in the editor, choose Format Document, and save. Do the same for timeConverter.test.js. Then commit and push.

Once both are pushed, add the Needs Review label again and I'll mark it Complete.

abdishakoor-dev · 2026-10-05T15:36:13Z

+    return `0${hours - 12}:${mints} pm`;
+  }
+  if(hours>=22){
+    return `${hours-12}:${mints} pm`;


In commit b1b6c72 you changed the minutes to 00, saw no test fail, and kept the line. That was the right experiment. When no test fails, it means a test is missing, not that the line is fine. A test that should have failed shows you where your tests have a gap.

The same gap is on this line now. If it returned :00 instead of the minutes, every test would still pass, because "23:00" is the only time you test after 10pm and its minutes are already 00. A "23:59" test closes that gap.

MaharitB added 11 commits October 4, 2026 13:45

added a test for 24:00 and test failed

f66d02c

fixed a bug to return12:00 when time given 24:00

3ce6795

fixed bug changed time ===24:00 and added am at line 4 and 5

0ec1be7

addes test for converting midday 12:00 to 12:00 pm

b54183b

test failed . fixing the bug. added a code on line 7 that returns 12:…

f1bf893

…00 pm

added a test , to convert time with minute. test failed

edf5168

added a test that coverts time at the end of midnight 00:59. test fai…

ab3e5fa

…led.

added a code for converting with min and converting end of midninght

1d4f08b

just making sure there is no redundancy in the coding

ce0ae5f

run prettier for timeConverter.test.js

8baa8cb

run prettier for timeConverter.js

cdcbc38

This comment has been minimized.

Sign in to view

MaharitB added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 4, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 4, 2026

MaharitB added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 4, 2026

abdishakoor-dev reviewed Oct 5, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 5, 2026

MaharitB added 10 commits October 5, 2026 11:57

changed the input in the function to be 00:00.and made some changes i…

0d2d87c

…n the program test success.

made three lines in comment if the test works with out the three line…

f0c87a6

… codes .test was success.

deleted three lines of code that were in a comment. test is success w…

405d9b5

…ith out it

changed the return ${mints}to 00, no test failed .kept the line

b1b6c72

wrote a test for the first begning of noon.test success

b516b52

fixed some errors on the test for begning of noon

f81b432

put the time===12 line in a comment and run the test and it wa success

6a3dca5

deleted the commented line of code .because test passed when run with…

355ec16

…out it

made the const stringHours on a comments to test run a test .Test was…

46fc4ac

… success .

deleted the line i commented and run prettier.

c8ec94b

MaharitB added 2 commits October 5, 2026 14:17

wrote a test to convert time later than midday with minutes.test failed

90adf7b

change code based on the test made for 13:00 and greater with min..tw…

3710e74

…o testes failed made amend based on that

MaharitB added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 5, 2026

abdishakoor-dev reviewed Oct 5, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 5, 2026

Navigation Menu

Uh oh!

London | 26-ITP-Sep | Maharit Belai | Sprint 1 | Format clock edge cases - #1645

London | 26-ITP-Sep | Maharit Belai | Sprint 1 | Format clock edge cases #1645
MaharitB wants to merge 23 commits into
CodeYourFuture:mainfrom
MaharitB:format-clock-edge-cases

MaharitB commented Oct 4, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

abdishakoor-dev left a comment

Uh oh!

abdishakoor-dev Oct 5, 2026

Uh oh!

abdishakoor-dev Oct 5, 2026

Uh oh!

abdishakoor-dev Oct 5, 2026

Uh oh!

abdishakoor-dev Oct 5, 2026

Uh oh!

abdishakoor-dev Oct 5, 2026

Uh oh!

abdishakoor-dev Oct 5, 2026

Uh oh!

abdishakoor-dev Oct 5, 2026

Uh oh!

MaharitB Oct 5, 2026

Uh oh!

abdishakoor-dev Oct 5, 2026

Uh oh!

abdishakoor-dev left a comment

Uh oh!

abdishakoor-dev Oct 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

MaharitB commented Oct 4, 2026

Learners, PR Template

Task code

Changelist

Questions

Uh oh!

This comment has been minimized.

This comment has been minimized.

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants