Skip to content

Fix Zod v4 schema description crash in agent-runtime #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nordicnode wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −4
Open

Fix Zod v4 schema description crash in agent-runtime #1201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/agent-runtime/src/__tests__/prompts-schema-handling.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ describe('Schema handling error recovery', () => {
expect(description).toContain('content')
})

test('buildToolDescription preserves MCP params when schema is represented as allOf', () => {
test('buildToolDescription preserves MCP params from converted schema', () => {
const mcpSchema = convertJsonSchemaToZod({
type: 'object',
properties: {
Expand All @@ -221,8 +221,8 @@ describe('Schema handling error recovery', () => {

expect(description).toContain('greet__greet')
expect(description).toContain('Params: {')
expect(description).toContain('allOf')
expect(description).toContain('name')
expect(description).toContain('cb_easp')
expect(description).not.toContain('Params: None')
})

Expand Down
6 changes: 5 additions & 1 deletion packages/agent-runtime/src/templates/prompts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ function ensureJsonSchemaCompatible(schema: z.ZodType): z.ZodType {
return schema
} catch {
const fallback = z.object({}).passthrough()
return schema.description ? fallback.describe(schema.description) : fallback
try {
return schema.description ? fallback.describe(schema.description) : fallback
} catch {
return fallback
}
}
}

Expand Down
6 changes: 5 additions & 1 deletion packages/agent-runtime/src/tools/prompts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ function ensureJsonSchemaCompatible(schema: z.ZodType): z.ZodType {
return schema
} catch {
const fallback = z.object({}).passthrough()
return schema.description ? fallback.describe(schema.description) : fallback
try {
return schema.description ? fallback.describe(schema.description) : fallback
} catch {
return fallback
}
}
}

Expand Down
Loading