Support Freebuff binary and environment variable in tmux test helper - #1205
Open
nordicnode wants to merge 1 commit into
Open
Support Freebuff binary and environment variable in tmux test helper#1205nordicnode wants to merge 1 commit into
nordicnode wants to merge 1 commit into
Conversation
Contributor
|
Nice, minimal change. The logic in A couple of minor things worth considering before porting:
Overall this is scoped correctly (dev script, not touching forbidden paths) and the diff is small enough to review cleanly. Worth porting with a quick sanity check on the binary-priority order and the referenced build script name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Freebuff binary and environment variable in tmux test helper
Summary
• Updates
scripts/tmux/tmux-start.shso testing with--binary(-b) detects the compiled Freebuff binary (cli/bin/freebuff) in addition to Codebuff (cli/bin/codebuff).• Prioritizes
FREEBUFF_BINARYalongsideCODEBUFF_BINARYin environment variable checks (${FREEBUFF_BINARY:-${CODEBUFF_BINARY:-}}).• Updates the missing-binary guidance message to include
bun run build:freebuff.• Prevents
Binary not found: .../cli/bin/codebufffailures when running tmux tests against a compiled binary in the Freebuff repository.Test plan
[✓] Tested
./scripts/tmux/tmux-start.sh -bresolving./cli/bin/freebuffcleanly without arguments[✓] Tested
FREEBUFF_BINARYoverride[✓] Verified PR hygiene checks pass cleanly