Support Windows paths and directory separators in path tab completion - #1212
Open
nordicnode wants to merge 1 commit into
Open
Support Windows paths and directory separators in path tab completion#1212nordicnode wants to merge 1 commit into
nordicnode wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Windows paths and directory separators in path tab completion
Summary
• In
cli/src/hooks/use-path-tab-completion.ts, fix path tab completion and automatic directory navigation on Windows.• Previously,
usePathTabCompletioncheckedsearchQuery.startsWith('/') || searchQuery.startsWith('~')for absolute paths. On Windows, drive paths (C:\...) and UNC paths were not matched, causing them to fall through to the relative path branch (path.join(currentPath, searchQuery)).• Furthermore,
completed.endsWith('/')was used to detect full directory completions. On Windows,path-completion.tsappendspath.sep(\), socompleted.endsWith('/')was always false, breaking automatic directory navigation when pressing Tab.• Exports pure helpers
isAbsolutePath,isCompleteDirectory, andtoRelativePathfromuse-path-tab-completion.tsto handle both POSIX and Windows path styles.• In
cli/src/hooks/__tests__/use-path-tab-completion.test.ts, uses the exported implementations and adds test cases for Windows drive paths and backslash directory completions.Test plan
[✓]
bun test --config=/dev/null src/hooks/__tests__/use-path-tab-completion.test.ts— 35 pass, 0 fail[✓]
bun run --cwd cli typecheck— 0 errors[✓] PR hygiene check passed