Support relative and absolute path keys in fileWindows lookup - #1213
Open
nordicnode wants to merge 1 commit into
Open
Support relative and absolute path keys in fileWindows lookup#1213nordicnode wants to merge 1 commit into
nordicnode wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support relative and absolute path keys in fileWindows lookup
Summary
• In
sdk/src/tools/read-files.ts, resolvefileWindowsusingfilePath,relativePath, orfullPath.• Previously,
windowswas looked up strictly viafileWindows?.[filePath]. IffilePathscontained an alias (e.g../src/file.tsor an absolute path/cwd/src/file.ts) whilefileWindowswas keyed by the canonicalrelativePath(src/file.ts), or vice versa, the lookup evaluated toundefined.• When
windowsisundefinedwhilefileWindowsis enabled, the code defaulted to[{}], dumping the whole file from line 1 and discarding the model's requested window offset/limit.• Adding fallback lookups for
fileWindows?.[relativePath]andfileWindows?.[fullPath]ensures requested windows are accurately applied regardless of path format.• Adds regression tests in
sdk/src/__tests__/read-files.test.tsverifying window resolution across relative, dot-slash, and absolute path variations.Test plan
[✓]
bun test src/__tests__/read-files.test.ts— 40 pass, 0 fail[✓]
bun run --cwd sdk typecheck— 0 errors[✓] PR hygiene check passed