Bound lines array in getLastNVisualLines to prevent unbounded memory growth - #1220
Open
nordicnode wants to merge 1 commit into
Open
Bound lines array in getLastNVisualLines to prevent unbounded memory growth#1220nordicnode wants to merge 1 commit into
nordicnode wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bound lines array in getLastNVisualLines to prevent unbounded memory growth
Summary
• In$O(n)$ ($n \le 5$ in preview) rather than $O(\text{total lines})$ .
cli/src/utils/text-layout.ts, bound thelinesaccumulator ingetLastNVisualLinesto at mostnlines.• Previously,
getLastNVisualLinesaccumulated every wrapped line from character 0 to the end of the text inlines: string[], only to slicelines.slice(-n)at the very end and discard the rest. When rendering long reasoning blocks, assistant messages, or terminal logs (e.g. 500+ lines), this held hundreds of unnecessary line strings in memory and required an additional.slice()array allocation.• Updated
pushLine()to evict the oldest line wheneverlines.length === nand sethasMore = true, ensuring memory used bylinesis strictly bounded by• Added comprehensive unit tests in
cli/src/utils/__tests__/text-layout.test.tscovering zero column/line inputs, small line counts, wrapping boundaries, and multi-hundred line inputs.Test plan
[✓]
bun test --config=/dev/null src/utils/__tests__/text-layout.test.ts— 11 pass, 0 fail[✓]
bun run --cwd cli typecheck— 0 errors[✓] PR hygiene check passed