Fix escapeString to properly escape HTML-unsafe characters - #1231
Open
pavankumar-vh wants to merge 1 commit into
Open
Fix escapeString to properly escape HTML-unsafe characters#1231pavankumar-vh wants to merge 1 commit into
pavankumar-vh wants to merge 1 commit into
Conversation
The escapeString function used JSON.stringify to escape a string, which handles quotes and backslashes but doesn't escape characters that are unsafe in HTML contexts: <, >, &, and '. This is a security concern if the escaped string is used in HTML or XML contexts, as it could allow XSS attacks or HTML injection. Added explicit escaping for these characters to prevent potential security issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix a potential XSS vulnerability in the
escapeStringfunction incommon/src/util/string.ts.Bug Description
The
escapeStringfunction usedJSON.stringifyto escape a string, which handles quotes and backslashes but doesn't escape characters that are unsafe in HTML contexts:<,>,&, and'.This is a security concern if the escaped string is used in HTML or XML contexts, as it could allow XSS attacks or HTML injection.
Fix
Added explicit escaping for these characters to prevent potential security issues:
<→\\u003c>→\\u003e&→\\u0026'→\\u0027Testing
No existing tests for this function, but the fix prevents potential XSS vulnerabilities.
Files Changed
common/src/util/string.ts- Added HTML-unsafe character escapingScope
This change only touches
common/which is an approved contribution area per the Contributing Guide.