Improve null handling in getNextQuotaReset - #1232
Open
pavankumar-vh wants to merge 1 commit into
Open
Conversation
The original code used 'referenceDate ?? now' which meant when referenceDate was null, it created a new Date from now, then the while loop would immediately add a month since nextMonth <= now would be true (they're equal). This is inefficient and the intent is unclear. Made the null case explicit: when referenceDate is null, return next month from now directly. When referenceDate is provided, start from that date and add months until it's in the future, which is the original behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Improve null handling in the
getNextQuotaResetfunction incommon/src/util/dates.ts.Bug Description
The original code used
referenceDate ?? nowwhich meant when referenceDate was null, it created a new Date from now, then the while loop would immediately add a month sincenextMonth <= nowwould be true (they're equal).This is inefficient and the intent is unclear.
Fix
Made the null case explicit:
Testing
No existing tests for this function, but the fix improves clarity and efficiency.
Files Changed
common/src/util/dates.ts- Improved null handlingScope
This change only touches
common/which is an approved contribution area per the Contributing Guide.