Fix NaN handling in getResponseAdForSlot - #1243
Open
pavankumar-vh wants to merge 1 commit into
Open
Conversation
The function didn't validate that slotIndex is a finite number. If slotIndex was NaN or Infinity, Math.floor(NaN) would return NaN, causing Math.max(0, NaN) to return NaN, and NaN % ads.length to return NaN. Added Number.isFinite() check to default to 0 for invalid numbers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix NaN handling in the
getResponseAdForSlotfunction incommon/src/util/lazy-response-ads.ts.Bug Description
The function didn't validate that slotIndex is a finite number. If slotIndex was NaN or Infinity,
Math.floor(NaN)would return NaN, causingMath.max(0, NaN)to return NaN, andNaN % ads.lengthto return NaN.Fix
Added
Number.isFinite()check to default to 0 for invalid numbers.Testing
No existing tests for this function, but the fix prevents incorrect behavior with invalid inputs.
Files Changed
common/src/util/lazy-response-ads.ts- Added NaN validationScope
This change only touches
common/which is an approved contribution area per the Contributing Guide.