Skip to content

Fix Infinity overflow in retry backoff calculation #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavankumar-vh wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

Fix Infinity overflow in retry backoff calculation #1246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion common/src/util/promise.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,9 @@ export async function withRetry<T>(

// Exponential backoff with jitter (±20%) to prevent thundering herd
const baseDelayMs = retryDelayMs * Math.pow(2, attempt)
const safeBaseDelayMs = Number.isFinite(baseDelayMs) ? baseDelayMs : Number.MAX_SAFE_INTEGER
const jitter = 0.8 + Math.random() * 0.4 // Random multiplier between 0.8 and 1.2
const delayMs = Math.round(baseDelayMs * jitter)
const delayMs = Math.round(safeBaseDelayMs * jitter)
await new Promise((resolve) => setTimeout(resolve, delayMs))
}
}
Expand Down
Loading