Skip to content

Fix NaN handling in getFreebuffStreakLine #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavankumar-vh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix NaN handling in getFreebuffStreakLine #1248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions common/src/util/freebuff-streak-line.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,9 @@ export function getFreebuffStreakLine(
// Fill toward the 7-day milestone, then stay full — a 19-day streak should
// read as fully earned, not roll back over into a partial second week. Past
// the week, a trailing "+" marks that the streak has run beyond the row.
const filled = Math.min(streak, FREEBUFF_STREAK_WEEK)
const beyond = streak > FREEBUFF_STREAK_WEEK
const safeStreak = Number.isFinite(streak) ? streak : 0
const filled = Math.min(safeStreak, FREEBUFF_STREAK_WEEK)
const beyond = safeStreak > FREEBUFF_STREAK_WEEK
const dots =
chars.filled.repeat(filled) +
chars.empty.repeat(FREEBUFF_STREAK_WEEK - filled) +
Expand All @@ -57,7 +58,7 @@ export function getFreebuffStreakLine(
// "day" stays singular — it's a compound modifier ("7 day streak"), not a
// count of days on its own.
return {
label: `${streak} day streak`,
label: `${safeStreak} day streak`,
dots,
progress: { filled, total: FREEBUFF_STREAK_WEEK, beyond },
}
Expand Down
Loading