You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for putting effort into localization — a Traditional Chinese README is a reasonable ask given the existing zh-CN one, and the translation itself reads as competent, fluent Chinese, not machine-mangled filler.
A few concerns that would need addressing before this is portable:
HK and TW variants are nearly identical. Diffing README.zh-HK.md and README.zh-TW.md shows only a handful of word-choice differences (本地/本機, 發佈/發布, 儲存庫 wording, etc.). That's a lot of duplicated content (224 lines) to maintain for marginal variation. A single README.zh-TW.md covering both Taiwan and Hong Kong usage (as is common practice) would be far easier to keep in sync, or note the few HK-specific terms inline instead of forking the whole file.
Generated data-use block. Both new files include a <!-- BEGIN GENERATED FREEBUFF DATA USE --> section, which in the main README is presumably auto-generated/templated from source data, not meant to be hand-translated and pasted. If that block changes upstream (model list, policy wording), these two new files will silently drift out of sync with no mechanism to catch it. Worth checking with maintainers how that section is generated before duplicating it by hand.
Missing trailing newline on both new files (\ No newline at end of file) — minor, but the repo's other README files end cleanly.
Given this is a squashed mirror, this specific PR's diff would need porting by hand — the duplication above makes that porting more error-prone and higher maintenance cost than the value added. Consolidating to one zh-TW file (or confirming with maintainers that HK deserves separate treatment) would make this much more likely to land.
Thanks for putting effort into localization — a Traditional Chinese README is a reasonable ask given the existing zh-CN one, and the translation itself reads as competent, fluent Chinese, not machine-mangled filler.
A few concerns that would need addressing before this is portable:
HK and TW variants are nearly identical. Diffing README.zh-HK.md and README.zh-TW.md shows only a handful of word-choice differences (本地/本機, 發佈/發布, 儲存庫 wording, etc.). That's a lot of duplicated content (224 lines) to maintain for marginal variation. A single README.zh-TW.md covering both Taiwan and Hong Kong usage (as is common practice) would be far easier to keep in sync, or note the few HK-specific terms inline instead of forking the whole file.
Generated data-use block. Both new files include a <!-- BEGIN GENERATED FREEBUFF DATA USE --> section, which in the main README is presumably auto-generated/templated from source data, not meant to be hand-translated and pasted. If that block changes upstream (model list, policy wording), these two new files will silently drift out of sync with no mechanism to catch it. Worth checking with maintainers how that section is generated before duplicating it by hand.
Missing trailing newline on both new files (\ No newline at end of file) — minor, but the repo's other README files end cleanly.
Given this is a squashed mirror, this specific PR's diff would need porting by hand — the duplication above makes that porting more error-prone and higher maintenance cost than the value added. Consolidating to one zh-TW file (or confirming with maintainers that HK deserves separate treatment) would make this much more likely to land.
I am considering to change HK version to Cantonese words(what hk people speak in,which is extremely different to TW and CN Chinese, grammatically and linguistically) asking for opinion
Also note that although TW and HK looks almost identical, TW is partially linguistically compatible to CN instead(both mandarin) and HK is separate ( the difference is larger than Spanish<->Portuguese<->Italian) @codebuff-team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bot:triagedClassified by the community triage botpr:needs-workRight idea, not mergeable as written
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added traditional Chinese addition (for both speaking region variants--Hong Kong and Taiwan