offsetbycodepoints function added #1590 #2453

sumitdethe27 · 2023-06-10T00:05:08Z

Java Strings: .offsetByCodePoints() Method Added- Issue fixed #1590

Type of Change

Adding a new entry

Checklist

[ x] All writings are my own.
[x ] My entry follows the Codecademy Docs style guide.
[x ] My changes generate no new warnings.
[ x] I have performed a self-review of my own writing and code.
[ x] I have checked my entry and corrected any misspellings.
[ x] I have made corresponding changes to the documentation if needed.
[x ] I have confirmed my changes are not being pushed from my forked main branch.
[ x] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
[ x] Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

CLAassistant · 2023-06-10T00:05:13Z

All committers have signed the CLA.

SSwiniarski

@sumitdethe27 I did a first review and left a few comments.

content/java/concepts/strings/terms/offsetByCodePoints/offsetByCodePoints.md

…yCodePoints.md Co-authored-by: SSwiniarski <[email protected]>

…nto offsetMethod

sumitdethe27 · 2023-06-10T22:50:15Z

@SSwiniarski I have made the changes, Please review.

SSwiniarski

@sumitdethe27 More comments.

SSwiniarski · 2023-06-11T12:23:19Z

content/java/concepts/strings/terms/offsetByCodePoints/offsetByCodePoints.md

+```
+
+- `startIndex` (int): The starting index in the string from which the offset is applied.
+


Suggested change

Remove extra line break.

SSwiniarski · 2023-06-11T12:24:47Z

content/java/concepts/strings/terms/offsetByCodePoints/offsetByCodePoints.md

+New Index: 7
+```
+
+## Example 2


You haven't addressed my issue with the duplicative examples:

The next two examples are essentially the same as the first one. It might be good to show an example of fetching a character from the middle of a string of completely non-Latin script.

@SSwiniarski In Example 3, I have added a completely non-latin script.

SSwiniarski

@sumitdethe27 some more comments.

SSwiniarski · 2023-06-11T19:30:55Z

content/java/concepts/strings/terms/offsetByCodePoints/offsetByCodePoints.md

+
+## Example 3
+
+In this example, the string str contains the text `"Hello, 世界!".` We specify the starting index as 0 and the code point offset as 5. The `**offsetByCodePoints()**` method returns the new index after applying the offset, which is 5 in this case. It means that the character at index 5 is the desired character.


You haven't updated the description to match.

Thank you for catching that mistake. I apologize for the confusion caused by the incorrect description. I have now updated the code and description to reflect the correct behavior.

SSwiniarski · 2023-06-11T19:32:00Z

content/java/concepts/strings/terms/offsetByCodePoints/offsetByCodePoints.md

+New Index: 7
+```
+
+## Example 2


Can you remove example two, as it pretty much duplicates example one.

sumitdethe27 · 2023-06-11T20:37:16Z

@SSwiniarski please review the changes.

SSwiniarski

@sumitdethe27 I forwarding this off to a second review.

sumitdethe27 · 2023-06-13T03:19:16Z

@sumitdethe27 I forwarding this off to a second review.

Thankyou

caupolicandiaz

@sumitdethe27 I've added several comments. Please update the entry, and tag me when you've finished making changes. Thanks

content/java/concepts/strings/terms/offsetByCodePoints/offsetByCodePoints.md

…yCodePoints.md Co-authored-by: caupolicandiaz <[email protected]>

sumitdethe27 · 2023-06-23T11:03:01Z

@caupolicandiaz I have made the changes

caupolicandiaz

@sumitdethe27 @SSwiniarski Looks good to merge

github-actions · 2023-06-23T16:38:00Z

👋 @sumitdethe27
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

SSwiniarski · 2023-06-23T16:43:57Z

@sumitdethe27 Congrats on the new entry. Live link here: https://www.codecademy.com/resources/docs/java/strings/offsetByCodePoints

You're currently anonymous. If you don't wish to be anonymous, check out this forum thread on how to link your GitHub and Codecademy profiles: https://discuss.codecademy.com/t/my-contribution-is-live-but-im-not-being-shown-as-a-contributor-why-is-this/758036 Note: it may take a few minutes for the change to register on the entry page.

sumitdethe27 · 2023-06-24T16:38:50Z

Thankyou @SSwiniarski

offsetbycodepoints function added

9179081

SSwiniarski added java Java entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels Jun 10, 2023

SSwiniarski self-assigned this Jun 10, 2023

SSwiniarski suggested changes Jun 10, 2023

View reviewed changes

SSwiniarski added status: review 1️⃣ completed status: waiting for author and removed status: under review Issue or PR is currently being reviewed labels Jun 10, 2023

sumitdethe27 and others added 3 commits June 11, 2023 03:34

Update content/java/concepts/strings/terms/offsetByCodePoints/offsetB…

9e435b8

…yCodePoints.md Co-authored-by: SSwiniarski <[email protected]>

applied the reviewd changes

cbc2059

Merge branch 'offsetMethod' of https://github.com/sumitdethe27/docs i…

9f20239

…nto offsetMethod

SSwiniarski suggested changes Jun 11, 2023

View reviewed changes

made the changes

70308f7

SSwiniarski approved these changes Jun 12, 2023

View reviewed changes

SSwiniarski added status: ready for next review and removed status: waiting for author labels Jun 12, 2023

Merge branch 'main' into offsetMethod

0712024

caupolicandiaz suggested changes Jun 22, 2023

View reviewed changes

caupolicandiaz added status: review 2️⃣ completed status: waiting for author and removed status: ready for next review labels Jun 22, 2023

sumitdethe27 and others added 3 commits June 23, 2023 16:12

Update content/java/concepts/strings/terms/offsetByCodePoints/offsetB…

460f18a

…yCodePoints.md Co-authored-by: caupolicandiaz <[email protected]>

Update content/java/concepts/strings/terms/offsetByCodePoints/offsetB…

9b00813

…yCodePoints.md Co-authored-by: caupolicandiaz <[email protected]>

Update content/java/concepts/strings/terms/offsetByCodePoints/offsetB…

affaf73

…yCodePoints.md Co-authored-by: caupolicandiaz <[email protected]>

sumitdethe27 and others added 4 commits June 23, 2023 16:21

Update content/java/concepts/strings/terms/offsetByCodePoints/offsetB…

509dd7c

…yCodePoints.md Co-authored-by: caupolicandiaz <[email protected]>

Update content/java/concepts/strings/terms/offsetByCodePoints/offsetB…

e60cc1d

…yCodePoints.md Co-authored-by: caupolicandiaz <[email protected]>

Update content/java/concepts/strings/terms/offsetByCodePoints/offsetB…

d816967

…yCodePoints.md Co-authored-by: caupolicandiaz <[email protected]>

Update content/java/concepts/strings/terms/offsetByCodePoints/offsetB…

138a404

…yCodePoints.md Co-authored-by: caupolicandiaz <[email protected]>

caupolicandiaz approved these changes Jun 23, 2023

View reviewed changes

caupolicandiaz removed the status: waiting for author label Jun 23, 2023

Merge branch 'main' into offsetMethod

f40f08c

SSwiniarski merged commit d4a8619 into Codecademy:main Jun 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

offsetbycodepoints function added #1590 #2453

offsetbycodepoints function added #1590 #2453

sumitdethe27 commented Jun 10, 2023

CLAassistant commented Jun 10, 2023 •

edited

Loading

SSwiniarski left a comment

sumitdethe27 commented Jun 10, 2023

SSwiniarski left a comment

SSwiniarski Jun 11, 2023

sumitdethe27 Jun 11, 2023 •

edited

Loading

SSwiniarski Jun 11, 2023

sumitdethe27 Jun 11, 2023

SSwiniarski left a comment

SSwiniarski Jun 11, 2023

sumitdethe27 Jun 11, 2023

SSwiniarski Jun 11, 2023

sumitdethe27 Jun 11, 2023

sumitdethe27 commented Jun 11, 2023

SSwiniarski left a comment

sumitdethe27 commented Jun 13, 2023

caupolicandiaz left a comment

sumitdethe27 commented Jun 23, 2023

caupolicandiaz left a comment

github-actions bot commented Jun 23, 2023

SSwiniarski commented Jun 23, 2023

sumitdethe27 commented Jun 24, 2023

		```

		- `startIndex` (int): The starting index in the string from which the offset is applied.


		## Example 3

		In this example, the string str contains the text `"Hello, 世界!".` We specify the starting index as 0 and the code point offset as 5. The `offsetByCodePoints()` method returns the new index after applying the offset, which is 5 in this case. It means that the character at index 5 is the desired character.

offsetbycodepoints function added #1590 #2453

offsetbycodepoints function added #1590 #2453

Conversation

sumitdethe27 commented Jun 10, 2023

Java Strings: .offsetByCodePoints() Method Added- Issue fixed #1590

Type of Change

Checklist

CLAassistant commented Jun 10, 2023 • edited Loading

SSwiniarski left a comment

Choose a reason for hiding this comment

sumitdethe27 commented Jun 10, 2023

SSwiniarski left a comment

Choose a reason for hiding this comment

SSwiniarski Jun 11, 2023

Choose a reason for hiding this comment

sumitdethe27 Jun 11, 2023 • edited Loading

Choose a reason for hiding this comment

SSwiniarski Jun 11, 2023

Choose a reason for hiding this comment

sumitdethe27 Jun 11, 2023

Choose a reason for hiding this comment

SSwiniarski left a comment

Choose a reason for hiding this comment

SSwiniarski Jun 11, 2023

Choose a reason for hiding this comment

sumitdethe27 Jun 11, 2023

Choose a reason for hiding this comment

SSwiniarski Jun 11, 2023

Choose a reason for hiding this comment

sumitdethe27 Jun 11, 2023

Choose a reason for hiding this comment

sumitdethe27 commented Jun 11, 2023

SSwiniarski left a comment

Choose a reason for hiding this comment

sumitdethe27 commented Jun 13, 2023

caupolicandiaz left a comment

Choose a reason for hiding this comment

sumitdethe27 commented Jun 23, 2023

caupolicandiaz left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 23, 2023

SSwiniarski commented Jun 23, 2023

sumitdethe27 commented Jun 24, 2023

CLAassistant commented Jun 10, 2023 •

edited

Loading

sumitdethe27 Jun 11, 2023 •

edited

Loading