Skip to content

Add contextual explanation for CSS color property values #6344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mnkth01a
Copy link

Description

Modified content/css/concepts/colors/terms/colors.md to provide better explanations of terms for CSS color values. Added proposed changes to each of the color: value. This revision adds more details that are concise enough for advanced users and has more details for beginners. Each section now provides links to related W3C topics.

Issue Solved

Closes #6309 titled "Add Contextual Explanation for CSS Color Property Values"

Type of Change

  • Adding a new entry

    • Added the proposed changes to each of the items listed.
    • Added a concise explanation of when and why each of the methods are used.
      image
  • Editing an existing entry (fixing a typo, bug, issues, etc)

  • Updating the documentation

    • Divided the Hexadecimal section into two separate sections labeled "Hexadecimal" and "Name Keyword". This is to distinguish them and to make it easier to see the difference between them with examples.
      image
      image

    • Included two new sections that give more information about those methods.
      image

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Mar 16, 2025

CLA assistant check
All committers have signed the CLA.

@mnkth01a mnkth01a changed the title Add contentual explanation for CSS color property values Add contextual explanation for CSS color property values Mar 16, 2025
@dakshdeepHERE dakshdeepHERE added enhancement New feature or request status: under review Issue or PR is currently being reviewed labels Mar 19, 2025
@dakshdeepHERE dakshdeepHERE self-assigned this Mar 19, 2025
@dakshdeepHERE dakshdeepHERE removed their assignment Mar 27, 2025
@dakshdeepHERE dakshdeepHERE removed the status: under review Issue or PR is currently being reviewed label Mar 27, 2025
@PragatiVerma18 PragatiVerma18 self-assigned this Mar 27, 2025
Copy link
Collaborator

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mnkth01a, thanks for contributing to docs, although this entry is missing some crucial things and needs changes -

  • Please remove .vscode/settings.json; it is not related and is not required here. The PR should only include file changes related to concepts.

  • Please remove the new file you have added, terms/colors/colors.md, as it is not required. You need to make the edits in the existing file, concepts/colors/colors.md.

  • Only add the requested sections in the issue, do not delete the pre-existing text.

  • Please ensure that the color snippets are loading in Markdown as per your screenshot—I can't see that in the GitHub preview. Also, please don't use URLs from some other unknown website.

I am closing this PR for now, but could you make the changes and then open it again for review? Feel free to let me know if you need help. Thanks.

@PragatiVerma18 PragatiVerma18 added the invalid This doesn't seem right; not eligible for Hacktoberfest label Mar 27, 2025
@mnkth01a mnkth01a deleted the add-content-to-CSS-explanation branch March 27, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right; not eligible for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants