wip Gm 366 app header dropdown #2161

thedoomshine · 2021-11-08T22:08:02Z

Overview

PR Checklist

Related to designs:
Related to JIRA ticket: ABC-123
I have run this code to verify it works
This PR includes unit tests for the code change

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

Adds optional beta sticker to CurriculumCards.

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

* Array scales didn't trigger transformation flow for values. This explicitly adds a check explicitly for arrays and adds a test to validate the behavior. * Improves logic for looking up scalar values with a hof that returns the appropriate logic (computations were unnecessarily checking the types of scales) * Splits out helpers to a separate file.

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

* Adds 2..5rem / 40 to our spacing intervals.

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

* Refactors the tool tips for system prop groups to display in a more human readable format and use existing components. * Fixes bug with selected prop group text color inheritance. * Removes legacy style patterns from files that were still referencing `gamut-system` code.

* Let's you specify `component="Box"` et al on our custom storybook internal link which sends you to our best guess story. This may not work for components that are not directly specified as a `component={X}` on a stories' meta configuration.

- @codecademy/[email protected]

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

### New * Modal component for abstract Modal dialogs that are not binary flows. * Moves Modal / Dialog / Overlay / ModalDeprecated to a new Molecule section `Modals`. * Creates shared components and types for `Modal` and `Dialog` for shared layout configuration and spacing. * Creates a new Modal documentation page with sizing examples. * Adds a fluid size for standard Modals that responds to content but is capped at the viewport. * Updates Overlays to accept a shroud boolean prop to add an opaque background. ### Modal Usage ```tsx <Modal title="My Modal Title" onRequestClose={() => {}}> Arbitrary content for arbitrary features! </Modal> ``` ### Overlay shroud ```tsx <Overlay shroud> // Content </Overlay> ``` ### Sizes <img width="1409" alt="Screen Shot 2021-08-10 at 12 15 07 PM" src="https://user-images.githubusercontent.com/52927224/128936160-5d0d15f2-5e69-490b-b194-d8820dea738b.png">

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

Small performance boost for expanded text within truncation component

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

- @codecademy/[email protected]

This PR adds a new `Testimonial` component to gamut that utilizes the `FloatingCard` component. The new component has updated styles and support for light/dark color modes. It has two variants horizontal/vertical but any implementation will go to vertical on mobile viewports.

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

Added the hyperlink 3 icon

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

Adds a `hidePricing` prop to hide the _Pro Pricing_ link.

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

* Fixes bad import path

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

- @codecademy/[email protected]

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

Adds the Maze illustration to `gamut-illustrations`.

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

Adds code challenge link to the list of resource in the global nav header

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

Adds an explicit `aria-label` prop. Also updates tests. Would like to type guard this in the future, but will hold off until converting GridForm inputs to ConnectedForms monolith alpha branch [here](codecademy-engineering/Codecademy#27756)

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

Add client tracking to user identification and events to track which users are interacting via the Chromebook PWA

- @codecademy/[email protected]

Changes `Drawer`'s internal `Box` to use `minWidth={fullWidth}`.

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

… child components Adding Dark Mode to GlobalHeader ahead of schedule for Voniel and CfB

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

* [GM-365] Replacing AppHeaderAvatar with Avatar * [GM-365] Deleting AppHeaderAvatar * [GM-365] cleaning up tests

CLAassistant · 2022-08-24T22:21:31Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
11 out of 12 committers have signed the CLA.

✅ timjenkins
✅ codecademy-gh-api
✅ dreamwasp
✅ aresnik11
✅ aionate0812
✅ codecaaron
✅ ahmed-abdallah
✅ natalieweesh
✅ jcenglish
✅ borisonr
✅ thedoomshine
❌ Yaron Shahverdi

Yaron Shahverdi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

codecademy-gh-api and others added 30 commits August 11, 2021 15:53

chore(release): publish

597a3b1

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

feat(SelectDropdown): ColorModes

c867505

chore(release): publish

3395ddc

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

feat(CurriculumCard): Add beta sticker option to CurriculumCard

84b30d5

Adds optional beta sticker to CurriculumCards.

chore(release): publish

9ab0bb6

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

feat: Add 2.5rem interval to spacing GM-317

755a224

* Adds 2..5rem / 40 to our spacing intervals.

chore(release): publish

be1113e

- @codecademy/[email protected]

feat(SelectDropdown): small variant

de29b2d

chore(release): publish

8ae1f74

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

feat(SelectDropdown): shownOptionsLimit

82b9cb0

chore(release): publish

8e44dff

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

chore(release): publish

99b6c33

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

fix: Performance boost for <Truncate />

7d15b2f

Small performance boost for expanded text within truncation component

chore(release): publish

af2bb06

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

categorize more segment categories into ontrust consent groups (#1956)

92cfbfd

chore(release): publish

251f23e

- @codecademy/[email protected]

feat(icon): hyper link 3 icon

2941361

Added the hyperlink 3 icon

chore(release): publish

636c7a8

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

feat: added hidePricing prop to GlobalFooter, GlobalHeader

6802441

Adds a `hidePricing` prop to hide the _Pro Pricing_ link.

chore(release): publish

bd4a9bb

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

fix: Import path

5aa461c

* Fixes bad import path

dreamwasp and others added 27 commits October 14, 2021 15:41

fix(SelectDropdown): event props

c5c21e7

chore(release): publish

1933aa4

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

fix(FormGroup): export interface from FormGroup

b4d5d20

chore(release): publish

ecf26c7

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

docs(Compose): update code snippets

da490fb

chore(release): publish

2540abb

- @codecademy/[email protected]

fix(FormGroupLabel):

b093308

chore(release): publish

3d54ae1

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

feat(Illustrations): Add Maze illustration to gamut-illustrations

3709941

Adds the Maze illustration to `gamut-illustrations`.

chore(release): publish

26b0abf

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

feat(CodeChallenges): add challenges to list of resources in global nav

3578e58

Adds code challenge link to the list of resource in the global nav header

chore(release): publish

67c0ac3

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

fix(Checkbox): adds aria-label prop

9d3a4d5

Adds an explicit `aria-label` prop. Also updates tests. Would like to type guard this in the future, but will hold off until converting GridForm inputs to ConnectedForms monolith alpha branch [here](codecademy-engineering/Codecademy#27756)

chore(release): publish

bbb6bee

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

feat(tracking): Add source tracking for PWA

84a555f

Add client tracking to user identification and events to track which users are interacting via the Chromebook PWA

chore(release): publish

9a4e6ee

- @codecademy/[email protected]

fix(Drawer): use minWidth instead of width in internal Box

d19d483

Changes `Drawer`'s internal `Box` to use `minWidth={fullWidth}`.

chore(release): publish

895952c

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

feat(PageAlerts): porting PageAlerts from Portal-App

9ab0dc1

chore(release): publish

fc53168

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

feat(GlobalHeader): [GM-399] Adding dark mode to GlobalHeader and all…

1148a31

… child components Adding Dark Mode to GlobalHeader ahead of schedule for Voniel and CfB

chore(release): publish

b4d0d15

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

fix(Alert): re-add default props

ef9f292

chore(release): publish

56f4bc3

- @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected] - @codecademy/[email protected]

refactor: [GM-365] Replacing AppHeaderAvatar with Avatar (#2073)

c5d51cd

* [GM-365] Replacing AppHeaderAvatar with Avatar * [GM-365] Deleting AppHeaderAvatar * [GM-365] cleaning up tests

[GM-366] wip

eb32718

[GM-366] too much

9216b4b

thedoomshine requested a review from songstephen as a code owner November 8, 2021 22:08

thedoomshine changed the title ~~Gm 366 app header dropdown~~ wip Gm 366 app header dropdown Nov 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wip Gm 366 app header dropdown #2161

wip Gm 366 app header dropdown #2161

thedoomshine commented Nov 8, 2021

CLAassistant commented Aug 24, 2022 •

edited

Loading

wip Gm 366 app header dropdown #2161

Are you sure you want to change the base?

wip Gm 366 app header dropdown #2161

Conversation

thedoomshine commented Nov 8, 2021

Overview

PR Checklist

CLAassistant commented Aug 24, 2022 • edited Loading

CLAassistant commented Aug 24, 2022 •

edited

Loading