Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(FramerMotion): upgrade #3007

Merged
merged 2 commits into from
Feb 11, 2025
Merged

chore(FramerMotion): upgrade #3007

merged 2 commits into from
Feb 11, 2025

Conversation

jrood
Copy link
Contributor

@jrood jrood commented Jan 16, 2025

Overview

  • Update framer motion to 11.18.0
  • Change motion() to motion.create()
  • Add optional href prop for PaginationButton to satisfy typescript since it can render as an anchor or button.

Testing Instructions

There should be no functional changes.
As a smoke test, check Drawer and the "Animation" example for Popover.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Mono PR Portal Env

@jrood jrood changed the title upgrade framer motion chore(FramerMotion): upgrade Jan 16, 2025
Copy link

nx-cloud bot commented Jan 16, 2025

View your CI Pipeline Execution ↗ for commit d8306d5.


☁️ Nx Cloud last updated this comment at 2025-02-11 21:33:13 UTC

@jrood jrood force-pushed the jrood.upgrade-framer-motion branch from be8bde6 to c3fba76 Compare January 16, 2025 15:33
@jrood jrood force-pushed the jrood.upgrade-framer-motion branch 3 times, most recently from 7bf66a5 to e15d183 Compare January 30, 2025 23:24
@jrood jrood force-pushed the jrood.upgrade-framer-motion branch 2 times, most recently from b543fa0 to b38f473 Compare February 3, 2025 20:41
@jrood jrood marked this pull request as ready for review February 3, 2025 22:26
@jrood jrood requested a review from a team as a code owner February 3, 2025 22:26
@jrood jrood force-pushed the jrood.upgrade-framer-motion branch from b38f473 to 7a3378f Compare February 6, 2025 16:17
@jrood jrood force-pushed the jrood.upgrade-framer-motion branch from 7a3378f to ce88cb5 Compare February 11, 2025 14:50
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]

Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for doing this!

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://67abc235290e5e48d843ad03--gamut-preview.netlify.app

Deploy Logs

@jrood jrood merged commit 3bb8c18 into main Feb 11, 2025
16 checks passed
@jrood jrood deleted the jrood.upgrade-framer-motion branch February 11, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants