chore(AppBar): move appbar from brand #3038
Conversation
|
View your CI Pipeline Execution ↗ for commit 23d79f4. ☁️ Nx Cloud last updated this comment at |
📬Published Alpha Packages:@codecademy/[email protected] |
|
🚀 Styleguide deploy preview ready! |
| alignItems="center" | ||
| height="100%" | ||
| size={wide ? 'wide' : 'medium'} | ||
| zIndex={14} |
There was a problem hiding this comment.
This feels like an arbitrary value lol
should it always be 14? should/could this value potentially be set by a prop?
There was a problem hiding this comment.
yeha that makes sense, i'll make it a prop
| <Canvas> | ||
| <Story of={AppBarStories.Header} /> | ||
| </Canvas> |
There was a problem hiding this comment.
For some reason this shows up in the page as the default story —
You can change it: <Canvas of={AppBarStories.Header} /> to get it show properly
It'd also be good to include a playground section below this and maybe format the whole story closer to the other stories we use for gamut's story pages
There was a problem hiding this comment.
yeah i just did a straight copy-paste, i'll fix it more
Overview
Moves AppBar from Brand to Gamut - first in a project to decouple AppHeader components from business logic
PR Checklist
Testing Instructions
PR Links and Envs