Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Page Rework #4355

Merged
merged 25 commits into from
Jan 28, 2025
Merged

Dashboard Page Rework #4355

merged 25 commits into from
Jan 28, 2025

Conversation

abaicus
Copy link
Collaborator

@abaicus abaicus commented Jan 15, 2025

Summary

Warning

A few things are not implemented:

  • The scroll to top module is still listed and not enabled by default as it would show up on user websites;
  • Customizer links should be checked at the end;
  • The pro plugins are not listed in the recommended plugins section;

Will affect visual aspect of the product

YES (on the backend)

Screenshots

image

Test instructions

Check before Pull Request is ready:

Ref Codeinwp/neve-pro-addon#2914.

@abaicus abaicus force-pushed the prf/feat/dashboard-page branch from fd24af0 to 6c8dc15 Compare January 15, 2025 16:05
@abaicus abaicus added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jan 15, 2025
@abaicus abaicus force-pushed the prf/feat/dashboard-page branch from 6c8dc15 to 3687c39 Compare January 15, 2025 16:32
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jan 15, 2025
@pirate-bot
Copy link
Collaborator

pirate-bot commented Jan 15, 2025

Plugin build for bb32209 is ready 🛎️!

@abaicus abaicus force-pushed the prf/feat/dashboard-page branch from 3687c39 to b643134 Compare January 15, 2025 16:38
@abaicus abaicus force-pushed the prf/feat/dashboard-page branch from b643134 to 12c26f6 Compare January 16, 2025 09:17
@abaicus abaicus changed the title [wip][tbd] Prf/feat/dashboard page Dashboard Page Rework Jan 16, 2025
Comment on lines +114 to +133
{tab === 'general' && (
<TransitionWrapper>
<GeneralTabContent />
</TransitionWrapper>
)}
{tab === 'performance' && (
<TransitionWrapper>
<PerformanceTabContent />
</TransitionWrapper>
)}
{tab === 'white-label' && (
<TransitionWrapper>
<WhiteLabelTabContent />
</TransitionWrapper>
)}
{tab === 'manage-modules' && (
<TransitionWrapper>
<ManageModulesTabContent />
</TransitionWrapper>
)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion: you can put <TransitionWrapper> outside the check since all of them are using it.

@rodica-andronache
Copy link
Contributor

rodica-andronache commented Jan 17, 2025

@abaicus some small things, I didn't manage to check everything yet:

@ineagu
Copy link

ineagu commented Jan 21, 2025

  • 1. We can hide in free the pro module
  • 2. move contributing sidebar after the recomm plugins
  • 3. let's add the join community after contributing section as well, but keep the fb group only
  • 4. @harshitarora-in can you redo the free vs pro table here, ideally submit a PR with the text changes?
  • 5. WHen I have the pro addon, without a license, I see an upgrade link in the manage modules section, can we have " add the license notice?"
  • 5. when the pro is installed, can we move the plugins section from the sidebar, after the customizer links?
  • 6. We can still show the white label tab in free and mark it as pro, we can show the settings as an image with a upgrade overlay on top
  • 7. Any reason we are not displaying the exact settings in free for those 2 modules? we can display them fakely using html/image and mark as pro : https://vertis.d.pr/i/kFwEiU. the value is that user sees exactly how this works.

@ineagu
Copy link

ineagu commented Jan 21, 2025

@abaicus I also used Claude to help on minor improvements :

  1. Add descriptions and change the section title for the customizer links: https://vertis.d.pr/i/wuedKM
  2. Add new descriptions for the modules: https://vertis.d.pr/i/UDeyMa (ignore the small line), use this checkmark pattern only for woo booster: https://vertis.d.pr/i/HaNBoc

@abaicus
Copy link
Collaborator Author

abaicus commented Jan 21, 2025

@ineagu can you please share the artefacts for the designs involving texts so I can use them? Thank you!

@harshitarora-in
Copy link
Contributor

@harshitarora-in can you redo the free vs pro table here, ideally submit a PR with the text changes?

@ineagu I’ve added the new text in Figma, and once you confirm it, I’ll create a PR for it.

Here’s the Figma link: https://www.figma.com/design/66Mckrcd3uSUmy3AGmFOmz/Product-Marketing?node-id=3050-2106&t=8EDpiqMmITQy1FSs-1

A few points to note:

  • I’ve included most of the PRO features we’re highlighting on the upgrade page as part of this FREE vs PRO table.
  • We can remove the mention of features like Scroll to top, Typekit fonts, etc.
  • The structure and feature names are aligned with the new upgrade page to maintain consistency and ensure users clearly understand the PRO version without any confusion.
  • One suggestion: previously, we redirected users to the respective documentation links. For this new table, can we add an icon next to the heading that links to the upgrade page and the specific feature area? For example, clicking on “Header Booster” would redirect to: themeisle.com/themes/neve/upgrade/headerbooster.

Let me know your thoughts!

@ineagu
Copy link

ineagu commented Jan 24, 2025

@harshitarora-in here are my thoughts : https://www.loom.com/share/11017346bf214828a3a89e0f2f6c62ac. do you wanna try a new design with claude, starting from that comparison page?

@abaicus
Copy link
Collaborator Author

abaicus commented Jan 27, 2025

  1. We can hide in free the pro module

Not sure I understand exactly what you mean here.

  1. @harshitarora-in can you redo the free vs pro table here, ideally submit a PR with the text changes?

I don't know what the next steps would be for this one.

  1. WHen I have the pro addon, without a license, I see an upgrade link in the manage modules section, can we have " add the license notice?"

Do you mean displaying a notice sitewide, or just in that respective tab? Usually when a user has a product downloaded from the store, the license auto-activates, so I think this is more or less an edge case (in which the license is inactive).

  1. We can still show the white label tab in free and mark it as pro, we can show the settings as an image with a upgrade overlay on top

My mistake here. I broke the conditions when making sure that the module settings don't show up in pro if the module is deactivated. It looks like below. Should the top-right link go to any page specifically?

image

  1. Any reason we are not displaying the exact settings in free for those 2 modules? we can display them fakely using html/image and mark as pro : https://vertis.d.pr/i/kFwEiU. the value is that user sees exactly how this works.

No. I will change them.

Thank you in advance!

@ineagu
Copy link

ineagu commented Jan 27, 2025

@abaicus the white label top link can go to the upgrade page.
free vs pro, can stay as it is now, since we don't have a final version from @harshitarora-in yet.
you can ignore the notice thing, I agree is edge case
for the first thing, I meant that we should hide modules for which the products are not present, like don't show that in pro we have EDD booster if user doesn't have edd

@harshitarora-in
Copy link
Contributor

@ineagu I will keep it as Free vs. PRO only because having a 3-tier comparison table might feel overwhelming for free users at first glance, especially since they’re not familiar with the plan names yet. It’s better to keep it simple for now. Besides, when users land on the upgrade page, they’ll see the full comparison anyway.

Here is what i propose for the text and headings

Group 54832 (1)

@ineagu
Copy link

ineagu commented Jan 27, 2025

okay, let's do this.

@harshitarora-in
Copy link
Contributor

@ineagu I have updated the content and committed the changes in this PR.

cc: @abaicus

@abaicus abaicus merged commit e955d40 into development Jan 28, 2025
13 of 14 checks passed
@abaicus abaicus deleted the prf/feat/dashboard-page branch January 28, 2025 07:31
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants