-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard Page Rework #4355
Dashboard Page Rework #4355
Conversation
fd24af0
to
6c8dc15
Compare
6c8dc15
to
3687c39
Compare
3687c39
to
b643134
Compare
b643134
to
12c26f6
Compare
{tab === 'general' && ( | ||
<TransitionWrapper> | ||
<GeneralTabContent /> | ||
</TransitionWrapper> | ||
)} | ||
{tab === 'performance' && ( | ||
<TransitionWrapper> | ||
<PerformanceTabContent /> | ||
</TransitionWrapper> | ||
)} | ||
{tab === 'white-label' && ( | ||
<TransitionWrapper> | ||
<WhiteLabelTabContent /> | ||
</TransitionWrapper> | ||
)} | ||
{tab === 'manage-modules' && ( | ||
<TransitionWrapper> | ||
<ManageModulesTabContent /> | ||
</TransitionWrapper> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion: you can put <TransitionWrapper>
outside the check since all of them are using it.
@abaicus some small things, I didn't manage to check everything yet:
|
|
@abaicus I also used Claude to help on minor improvements :
|
@ineagu can you please share the artefacts for the designs involving texts so I can use them? Thank you! |
@ineagu I’ve added the new text in Figma, and once you confirm it, I’ll create a PR for it. Here’s the Figma link: https://www.figma.com/design/66Mckrcd3uSUmy3AGmFOmz/Product-Marketing?node-id=3050-2106&t=8EDpiqMmITQy1FSs-1 A few points to note:
Let me know your thoughts! |
@harshitarora-in here are my thoughts : https://www.loom.com/share/11017346bf214828a3a89e0f2f6c62ac. do you wanna try a new design with claude, starting from that comparison page? |
Not sure I understand exactly what you mean here.
I don't know what the next steps would be for this one.
Do you mean displaying a notice sitewide, or just in that respective tab? Usually when a user has a product downloaded from the store, the license auto-activates, so I think this is more or less an edge case (in which the license is inactive).
My mistake here. I broke the conditions when making sure that the module settings don't show up in pro if the module is deactivated. It looks like below. Should the top-right link go to any page specifically?
No. I will change them. Thank you in advance! |
@abaicus the white label top link can go to the upgrade page. |
@ineagu I will keep it as Free vs. PRO only because having a 3-tier comparison table might feel overwhelming for free users at first glance, especially since they’re not familiar with the plan names yet. It’s better to keep it simple for now. Besides, when users land on the upgrade page, they’ll see the full comparison anyway. |
okay, let's do this. |
🎉 This PR is included in version 4.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Warning
A few things are not implemented:
Will affect visual aspect of the product
YES (on the backend)
Screenshots
Test instructions
Check before Pull Request is ready:
[ ] I have written a test and included it in this PRRef Codeinwp/neve-pro-addon#2914.