Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use only the onboarding workflow to selecting a starter site #423

Merged

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Jan 9, 2025

Summary

  • Make the sidebar menu redirect to the Onboarding workflow.
  • Welcome step will be only for first time users (the auto redirect when the user install TPC for the first time) with URL param show=welcome

Will affect visual aspect of the product

NO

Test instructions

  • Press on the Starter Sites under Neve menu. You should be redirected to onboarding.
  • After you complete an import, you should still be able to access the onboarding via Starter Sites under Neve menu.

Note

For Neve Dashboard shortcut, use Codeinwp/neve#4351

2025-01-10_11-26-56.mp4

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/2910

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jan 9, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Jan 9, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review January 9, 2025 13:40
@pirate-bot
Copy link
Collaborator

pirate-bot commented Jan 9, 2025

Plugin build for 511e26b is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jan 10, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the refactor/redirect-to-onboarding branch from 0f5d68c to 511e26b Compare January 13, 2025 12:04
@Soare-Robert-Daniel Soare-Robert-Daniel changed the base branch from development to feat/onboarding-revamp January 17, 2025 15:42
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit c031132 into feat/onboarding-revamp Jan 17, 2025
8 of 9 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the refactor/redirect-to-onboarding branch January 17, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants