-
Notifications
You must be signed in to change notification settings - Fork 0
Added Testcases #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are the comments for code and files ?
| } | ||
|
|
||
| const listenHandler = async <T>(db_url: string, opitons: Options<T>) => { | ||
| export const listenHandler = async <T>(db_url: string, opitons: Options<T>) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we make this exported ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sir, inorder to write testcases for it
| }; | ||
|
|
||
| const subscribeHandler = async <T>(db_url: string, opitons: Options<T>) => { | ||
| export const subscribeHandler = async <T>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we made this public ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To write testcases for it sir
| @@ -0,0 +1,15 @@ | |||
| import { jest } from '@jest/globals'; | |||
|
|
|||
| if (typeof window !== 'undefined') { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this setup ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reffered other projects for jest setup sir, but I think this is not needed in this
| import { getQueue } from '../queue-adapters/adapter'; | ||
|
|
||
| const getHandler = async <T>(consumer: Consumer<T>) => { | ||
| export const getHandler = async <T>(consumer: Consumer<T>) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we export this ?
It is in the first PR |
No description provided.