Skip to content

Conversation

@aakanksha994
Copy link
Collaborator

No description provided.

Copy link
Contributor

@vijayamadhavareddy vijayamadhavareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the comments for code and files ?

}

const listenHandler = async <T>(db_url: string, opitons: Options<T>) => {
export const listenHandler = async <T>(db_url: string, opitons: Options<T>) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we make this exported ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir, inorder to write testcases for it

};

const subscribeHandler = async <T>(db_url: string, opitons: Options<T>) => {
export const subscribeHandler = async <T>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we made this public ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To write testcases for it sir

@@ -0,0 +1,15 @@
import { jest } from '@jest/globals';

if (typeof window !== 'undefined') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this setup ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reffered other projects for jest setup sir, but I think this is not needed in this

import { getQueue } from '../queue-adapters/adapter';

const getHandler = async <T>(consumer: Consumer<T>) => {
export const getHandler = async <T>(consumer: Consumer<T>) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we export this ?

@aakanksha994
Copy link
Collaborator Author

Where are the comments for code and files ?

It is in the first PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants