Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-869805t7e alt names fixes #520

Merged
merged 7 commits into from
Feb 24, 2025
Merged

CU-869805t7e alt names fixes #520

merged 7 commits into from
Feb 24, 2025

Conversation

mart-r
Copy link
Collaborator

@mart-r mart-r commented Feb 18, 2025

Fix some alternative name stuff:

  • Separate the picking of appropriate category name
  • Select category name correctly when using the MetaCAT.eval method
  • Fix usage of alternative_class_names when encoding category names
    • I.e use the correct class name rather than the list of the class name as a key in category_value2id
  • Some other minor changes
    • Lowering indentation
    • Removing duplicate exceptions

@tomolopolis
Copy link
Member

Task linked: CU-869805t7e MetaCAT alternative name fixes

Copy link
Collaborator

@shubham-s-agarwal shubham-s-agarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mart-r mart-r merged commit 6f3403e into master Feb 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants