CU-8698ek477: Fix AdamW import from tranformers to torch #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mart-r
changed the title
mart-r
added a commit
that referenced
this pull request
Mar 24, 2025
* CU-8698ek477: Add TODO to MetaCAT ML utils regarding AdamW import * CU-8698ek477: Fix AdamW import (trf->torch)
mart-r
added a commit
that referenced
this pull request
Mar 24, 2025
* CU-8698ek477: Add TODO to MetaCAT ML utils regarding AdamW import * CU-8698ek477: Fix AdamW import (trf->torch)
mart-r
added a commit
that referenced
this pull request
Mar 24, 2025
* CU-8698ek477: Add TODO to MetaCAT ML utils regarding AdamW import * CU-8698ek477: Fix AdamW import (trf->torch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
transformers==4.50.0theAdamWimplementation was removed and the suggestion was to use the version intorch.optiminstead:huggingface/transformers#36177
Before the change to the import (the first commit in thie branch / PR), the GHA workflow will fail due to this import not existing and our loose dependencies.
Though the change is rather simple - just change the import. And the 2nd commit workflow should be successful.