Remove lean offset multiplier for targeting#4438
Draft
mszabo-wikia wants to merge 1 commit intoDevelopmentfrom
Draft
Remove lean offset multiplier for targeting#4438mszabo-wikia wants to merge 1 commit intoDevelopmentfrom
mszabo-wikia wants to merge 1 commit intoDevelopmentfrom
Conversation
This seems to have a positive effect on accuracy when targeting leaning pawns at narrow angles.
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-21332771716.zip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Remove multiplier applied to lean offset when computing LoS and target position offset.
Reasoning
This seems to have a positive effect on accuracy when targeting leaning pawns at narrow angles.
Without it, shooters are liable to hit the cover the target is leaning out from even at closer ranges.
Alternatives
Describe alternative implementations you have considered, e.g.
Testing
Check tests you have performed: