Open
Conversation
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23364595956.zip |
github-actions
bot
added
the
Download in Comments
perkinslr
force-pushed
the
cache-highest-cover
branch
from
c20578b to
3cc0825
Compare
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23364992608.zip |
ViralReaction
approved these changes
Mar 21, 2026
Contributor
ViralReaction
left a comment
ViralReaction
left a comment
There was a problem hiding this comment.
Everything looks good except for possible conflict with another pending PR.
ViralReaction
previously approved these changes
Mar 21, 2026
perkinslr
force-pushed
the
cache-highest-cover
branch
from
9145330 to
73be356
Compare
ViralReaction
previously approved these changes
Mar 21, 2026
perkinslr
dismissed
ViralReaction’s stale review
The merge-base changed after approval.
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23393514511.zip |
mszabo-wikia
previously approved these changes
Mar 22, 2026
perkinslr
dismissed
mszabo-wikia’s stale review
The merge-base changed after approval.
N7Huntsman
previously approved these changes
Mar 23, 2026
perkinslr
dismissed
N7Huntsman’s stale review
The merge-base changed after approval.
N7Huntsman
previously approved these changes
Mar 23, 2026
perkinslr
dismissed
N7Huntsman’s stale review
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additions
Adds highest cover cache to the lighting tracker
Changes
Uses cache-based early out for impact and shot line calculations
References
Reasoning
When scanning for targets in large battles, multiple pawns and multiply flying projectiles all end up cycling through all Things in cells to find the tallest. That answer effectively cannot change mid-tick (strictly, it can, if something is destroyed, but with the way the cache is used, this doesn't matter, at worst it causes an off-by-one-tick issue with projectiles not impacting pawns which pop up from downed right as the projectile flies overhead).
This substantially reduces the shot line calculation costs, and the bullet flight costs in large battles.
Testing
Check tests you have performed: