Temporary workaround for upstream MP bug. Will revert once it updates on steam#4519
Open
perkinslr wants to merge 1 commit intoDevelopmentfrom
Open
Temporary workaround for upstream MP bug. Will revert once it updates on steam#4519perkinslr wants to merge 1 commit intoDevelopmentfrom
perkinslr wants to merge 1 commit intoDevelopmentfrom
Conversation
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23369430956.zip |
github-actions
bot
added
the
Download in Comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Use explicitly typed SyncWorker registration
Reasoning
A bug in Multiplayer introduced in 1.6 breaks auto type detection on SyncWorker attributes. It's fixed upstream, but it's unclear how long until that fix lands on steam. This is a temporary fix until then.
Alternatives
Make people grab this as a draft PR or use the non-steam (github) version of Multiplayer
Testing
Check tests you have performed: