Skip to content

Fix HEDP cookoff null SoundDef#4520

Open
N7Huntsman wants to merge 1 commit intoDevelopmentfrom
HEDP-Cookoff-Fix
Open

Fix HEDP cookoff null SoundDef#4520
N7Huntsman wants to merge 1 commit intoDevelopmentfrom
HEDP-Cookoff-Fix

Conversation

@N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented Mar 22, 2026

Additions

  • Patch Bullet damageDef to have an explosion sound.

References

Reasoning

  • When these rounds cookoff, they use soundExplosion from the damageDef, which Bullet doesn't have since in vanilla the damage type isn't otherwise tied to explosions. Set it to use the same soundDef as the Bomb damage type.

Alternatives

  • Could rework the cookoff sound to use cookOffSound as sent in xml rather than the explosion sound, as the code currently doesn't appear to support this.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners March 22, 2026 16:12
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23407085025.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Download in Comments This PR has a zipfile download available.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: HEDP ammo detonation logs "SoundDef was null for DamageDef Bullet"

1 participant