Skip to content

VFE - Factory patch#4522

Merged
N7Huntsman merged 5 commits intoCombatExtended-Continued:Developmentfrom
chief-turkler:Development
Mar 23, 2026
Merged

VFE - Factory patch#4522
N7Huntsman merged 5 commits intoCombatExtended-Continued:Developmentfrom
chief-turkler:Development

Conversation

@chief-turkler
Copy link
Copy Markdown
Contributor

@chief-turkler chief-turkler commented Mar 23, 2026

Changes

Patched factory mortar shell recipes to reflect Combat Extended costs, and removed references to VFE-D shells that Combat Extended removes.

I plan to make a seperate pull request adding some FMJ ammo recipes to the ammo factory sometime in the future. This pull request is to get the mod into a good state with Combat Extended.

image

This patch was 'ready' before but Combat Extended was basically unplayable with VFE - Factory for a while due to a mishandling of stuffable categories on their end. That has now been fixed, and with that fix combined with this pull request, the mod is finally stable with Combat Extended.

Reasoning

image

Most mortar recipes (except for EMP shells) had their component cost rolled into their steel cost, as the ammo factory has only two inputs.
image
I think this is okay, as these are mid/late game factories capable of mass production and this isn't a huge issue. Certainly fits the theme, factory buildings have some notable advantages like being able to craft some normally uncraftable items or getting more nutrition out of food, shells not requiring a component crafting step (but still costing the same) fits in just fine, I think.

image

FYI for testers - it may look like the steel costs of some shells are too big to input with hoppers this way. Factories can 'hold' resources so you can input multiple stacks of steel through the same hopper.

image

Testing

Check tests you have performed:

  • Compiles without warnings - changes do not require a recompile
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long) 20-30 minutes of messing around in devmode

@chief-turkler chief-turkler requested review from a team as code owners March 23, 2026 07:59
@github-actions
Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23427119846.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Mar 23, 2026
@github-actions
Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23462741655.zip

@github-actions
Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23463398381.zip

N7Huntsman
N7Huntsman previously approved these changes Mar 23, 2026
Copy link
Copy Markdown
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues, but the factory is limited to producing the basic 81mm shells. We'd have to find a way to connect it into the ammoinjector is some fashion to make other calibers, which would not be a simple task.

@github-actions
Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23463840557.zip

@N7Huntsman N7Huntsman merged commit 308ec41 into CombatExtended-Continued:Development Mar 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Download in Comments This PR has a zipfile download available.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants