Open
Conversation
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23638613893.zip |
github-actions
bot
added
the
Download in Comments
perkinslr
force-pushed
the
more-hitchance
branch
from
2bbf043 to
f169ebc
Compare
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23638699112.zip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Several fixes in the vertical portion of the hit chance calculation
Reasoning
There were multiple math errors that resulted in the vertical hit chance almost always being 100%, making it meaningless. This resolves those issues.
Alternatives
The hit chance in the tooltip always assumes shooting the target in the center of visible area. This is because when that tooltip is generated, the point-of-impact calculation hasn't run yet, and there isn't a good handle with which to do so.
Testing
Check tests you have performed: