Skip to content

Further fixes for hit chances#4532

Open
perkinslr wants to merge 1 commit intoDevelopmentfrom
further-hit-chance-fixes
Open

Further fixes for hit chances#4532
perkinslr wants to merge 1 commit intoDevelopmentfrom
further-hit-chance-fixes

Conversation

@perkinslr
Copy link
Copy Markdown
Contributor

Changes

Pick the faster branch when possible

Reasoning

When the p-value is exactly 0.5, both branches produce the same value. In this case, the branch that avoids the extra subtraction is marginally faster, so prefer it.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@perkinslr perkinslr requested review from a team as code owners March 27, 2026 21:22
@github-actions
Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23668086548.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Download in Comments This PR has a zipfile download available.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant