-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
171 documentation become the comment master #193
Open
ymmot239
wants to merge
19
commits into
main
Choose a base branch
from
171-documentation-become-the-comment-master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commented all of the game and setup files, need to finish commenting the chessboard ones.
Completed the last of the chessboard and debug comments.
Completed common comments and fixed client comments
fun and interesting
Finished the comments for server folder. Hopefully tcp-interface is clear and accurate enough
placeholder
finished all the inner comments for the client files
Added comments to needed files in common and server. Also ran prettier for once
Filled in comments I missed in the first passes. All files should now have some level of descriptive commenting.
merged main into documentation and added appropriate comments
Could you add spaces after all of the |
as requested
Added clarification to some of the comments.
Merged in main and made comments on most of the new simulator code. Should probably be reviewed by Jason for accuracy.
Added comments to the new merge for spectator fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for most of the files.
Shouldn't have an effect on most of the running code, given they are mostly readability changes.