fix(chat): restore first-turn fly-in after workspace change - #139
Merged
Tomlord1122 merged 1 commit intoSep 11, 2026
Merged
Conversation
Detect first turn via empty cache (not hasVisibleConversation/loading), and reset composer phase + flight flags remount-equivalently on sessionId change so /change forks keep FirstTurnFlight and follow-up transitions without Cmd+R.
tomtom-bot40
left a comment
Collaborator
There was a problem hiding this comment.
Standards
Focused fix across ChatView + conversation-controller + /change. No blocking smells. Tests updated for empty-cache firstTurn and remount-equivalent bind.
Spec
Matches the agreed Spec for soft workspace/session swap:
firstTurnviagetCachedItemCount === 0(nothasVisibleConversation/ loading)- Soft
sessionIdswap is remount-equivalent (abort flights, clear handoffs,firstTurnFlightDone = cachedCount > 0, empty idle → empty snapshot +centerComposer()) - Do not dock solely for
isLoading /changecenters before soft goto
Also covers follow-up transitions stuck until Cmd+R by resetting composer phase on soft swap.
Standards: pass · Spec: pass · pre-PR two-axis sign-off stands
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/change(fork) left ChatView mounted with loading flags that madehasVisibleConversationtrue, docked the composer, and skippedFirstTurnFlight— and stuck follow-up transitions until Cmd+R.getCachedItemCount(sessionId) === 0instead of!hasVisibleConversation().sessionIdchange, remount-equivalent reset: abort flights, clear handoffs, setfirstTurnFlightDonefrom cache, center empty idle sessions; stop docking solely forisLoading./changecenters composer before softgoto.Test plan
/changeto another workspace → send first message → hero fly-in + dock runsviteston conversation-controller / thread-visibility / start-chat / composer-focus / first-turn-flight (60/60 locally)Reviewed two-axis by tomtom.bot40 @
c0ddcf2.