Skip to content

fix(ui): keep EmptyChatState when fork only has status - #141

Merged
Tomlord1122 merged 1 commit into
Cometline:mainfrom
tomtom-bot7:fix/empty-fork-keep-empty-chat-state
Sep 11, 2026
Merged

fix(ui): keep EmptyChatState when fork only has status#141
Tomlord1122 merged 1 commit into
Cometline:mainfrom
tomtom-bot7:fix/empty-fork-keep-empty-chat-state

Conversation

@tomtom-bot7

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #140 (merged at 5142fac). Empty-session /change still hid the hero avatar: fork system notes made hasVisibleConversation true (items.length > 0) while the composer stayed centered → blank half-hero.

  • Bound-session hasVisibleConversation now uses hasCachedConversationTurns (user|assistant only)
  • Mid-switch snapshot path likewise ignores status-only rows

Test plan

  • New empty session → /change → EmptyChatState / avatar still visible, composer centered
  • First message still runs FirstTurnFlight
  • Session with real messages still docks / shows thread

Previously two-axis signed off as d1a43aa on the #140 tip (landed after that merge cut).

Status-only transcripts made hasVisibleConversation true, which hid the
hero avatar while the composer stayed centered after /change.

@tomtom-bot40 tomtom-bot40 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standards

Same patch as previously reviewed d1a43aa (cherry-pick 8b1c24b). Clean.

Spec

hasVisibleConversation uses hasCachedConversationTurns / snapshot user|assistant — status-only fork keeps EmptyChatState + avatar. Prior two-axis on d1a43aa still applies.

Standards: pass · Spec: pass · tip confirmed

@Tomlord1122
Tomlord1122 merged commit 15ec3df into Cometline:main Sep 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants