[main] fix: recover tool json without false positives - #145
Merged
Merged
Conversation
New installs and unset maxTokens now allow 4k output per model step so medium documents are less likely to truncate a write_file or run_command payload. Existing saved settings are unchanged. Signed-off-by: Tom Liu (Liu Hsiu-Chi) <0xtomlord1122@gmail.com>
Successful tool output that mentions the error marker no longer opens the schema circuit. Only flagged unmarshal failures count, and a later complete JSON object in the same step still runs. Signed-off-by: Tom Liu (Liu Hsiu-Chi) <0xtomlord1122@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
A single model step still shares one output budget across assistant text and tool JSON. The previous 2048 default cut off medium job descriptions before the arguments were valid JSON. After that recovery landed, reading a file that mentioned the error marker could also look like a schema failure and skip later tools.
d38c627: New installs and unset maxTokens now default to 4096. Saved settings keep whatever the user already chose.
bb1fa41: Schema recovery now uses an explicit invalid-input flag instead of scanning tool output. Complete JSON objects in the same step still run after two truncated payloads.