refactor(assets): collapse useMediaAssets factory wrapper (FE-727)#12283
Open
dante01yoon wants to merge 4 commits into
Open
refactor(assets): collapse useMediaAssets factory wrapper (FE-727)#12283dante01yoon wants to merge 4 commits into
dante01yoon wants to merge 4 commits into
Conversation
useAssetsApi and useInternalFilesApi both delegate to the same assetsStore actions (updateInputs/updateHistory/loadMoreHistory). The wrapper-level isCloud switch in useMediaAssets was redundant with the existing branch inside assetsStore.fetchInputFiles. Collapse useMediaAssets to call useAssetsApi directly and delete the duplicate wrapper. No behavior change.
dosubot
Bot
added
the
size:M
Contributor
📝 WalkthroughWalkthroughThe PR completes removal of the ChangesMedia Assets API Consolidation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1607 passed, 0 failed · 2 flaky📊 Browser Reports
|
🎨 Storybook: ✅ Built — View Storybook |
📦 Bundle: 5.38 MB gzip 🟢 -48 BDetailsSummary
Category Glance App Entry Points — 26.1 kB (baseline 26.1 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.24 MB (baseline 1.24 MB) • 🟢 -4 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 82.9 kB (baseline 82.9 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 527 kB (baseline 527 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 14 unchanged User & Accounts — 17.8 kB (baseline 17.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed UI Components — 58 kB (baseline 58 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 3.16 MB (baseline 3.16 MB) • 🟢 -1.73 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 367 kB (baseline 367 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 18 unchanged Vendor & Third-Party — 9.94 MB (baseline 9.94 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 9.22 MB (baseline 9.22 MB) • 🟢 -4 BBundles that do not match a named category
Status: 57 added / 57 removed / 86 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-05-18T03:11:55.353Z",
"gitSha": "3a94ceab2525d37771ec5b0a4d0e7a51d7a6101a",
"branch": "jaewon/refactor-remove-useinternalfilesapi-wrapper",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2032.2300000000268,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.424000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.299,
"heapDeltaBytes": 23173708,
"heapUsedBytes": 71785384,
"domNodes": 16,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 19.689999999999994,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1998.7039999999752,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.703000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.062,
"heapDeltaBytes": 23231940,
"heapUsedBytes": 73350140,
"domNodes": 16,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 17.174000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1876.340999999968,
"styleRecalcs": 77,
"styleRecalcDurationMs": 42.385000000000005,
"layouts": 12,
"layoutDurationMs": 3.880000000000001,
"taskDurationMs": 776.2739999999999,
"heapDeltaBytes": 19115464,
"heapUsedBytes": 68297664,
"domNodes": 61,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 133.77800000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2019.679999999994,
"styleRecalcs": 80,
"styleRecalcDurationMs": 45.090999999999994,
"layouts": 12,
"layoutDurationMs": 3.597,
"taskDurationMs": 976.6669999999999,
"heapDeltaBytes": 21649408,
"heapUsedBytes": 71974696,
"domNodes": 62,
"jsHeapTotalBytes": 18350080,
"scriptDurationMs": 131.959,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.8039999999683,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.927999999999997,
"layouts": 6,
"layoutDurationMs": 0.5889999999999999,
"taskDurationMs": 296.204,
"heapDeltaBytes": 596348,
"heapUsedBytes": 48578796,
"domNodes": 80,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 23.991000000000007,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1747.3430000000008,
"styleRecalcs": 32,
"styleRecalcDurationMs": 22.439999999999998,
"layouts": 6,
"layoutDurationMs": 0.702,
"taskDurationMs": 391.72399999999993,
"heapDeltaBytes": 846836,
"heapUsedBytes": 50197048,
"domNodes": 79,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 35.143,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 536.9570000000294,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.486,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.123,
"heapDeltaBytes": 9182404,
"heapUsedBytes": 57805004,
"domNodes": 18,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 57.67999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 592.7769999999555,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.130000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.625,
"heapDeltaBytes": 16385088,
"heapUsedBytes": 67140756,
"domNodes": 19,
"jsHeapTotalBytes": 18874368,
"scriptDurationMs": 61.168,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2015.3399999999806,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.514000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.1550000000001,
"heapDeltaBytes": 13028152,
"heapUsedBytes": 71467676,
"domNodes": -259,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 88.78800000000001,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2011.9869999999764,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.039,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.635,
"heapDeltaBytes": -98588,
"heapUsedBytes": 59809136,
"domNodes": -261,
"jsHeapTotalBytes": 3756032,
"scriptDurationMs": 97.10499999999999,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2145.4080000000317,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.94,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1088.7669999999998,
"heapDeltaBytes": -689392,
"heapUsedBytes": 58433780,
"domNodes": -264,
"jsHeapTotalBytes": 757760,
"scriptDurationMs": 396.74899999999997,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2126.7560000000003,
"styleRecalcs": 69,
"styleRecalcDurationMs": 19.522000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1140.5749999999998,
"heapDeltaBytes": 7311784,
"heapUsedBytes": 66642668,
"domNodes": -260,
"jsHeapTotalBytes": 757760,
"scriptDurationMs": 414.48400000000004,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3130.574000000024,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.968000000000004,
"layouts": 60,
"layoutDurationMs": 7.128000000000001,
"taskDurationMs": 1315.561,
"heapDeltaBytes": 8301744,
"heapUsedBytes": 68956092,
"domNodes": -268,
"jsHeapTotalBytes": 5795840,
"scriptDurationMs": 491.51399999999995,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3217.1829999999773,
"styleRecalcs": 64,
"styleRecalcDurationMs": 19.517000000000003,
"layouts": 60,
"layoutDurationMs": 8.02,
"taskDurationMs": 1508.4599999999998,
"heapDeltaBytes": 10114588,
"heapUsedBytes": 71758260,
"domNodes": -270,
"jsHeapTotalBytes": 1339392,
"scriptDurationMs": 545.289,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2035.035999999991,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.348000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.241,
"heapDeltaBytes": 2481300,
"heapUsedBytes": 63345876,
"domNodes": -264,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 88.66900000000001,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2047.8029999999308,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.394000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 773.57,
"heapDeltaBytes": 43391044,
"heapUsedBytes": 105114696,
"domNodes": -262,
"jsHeapTotalBytes": 32796672,
"scriptDurationMs": 121.31,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 545.029999999997,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.085999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.33899999999994,
"heapDeltaBytes": 8817376,
"heapUsedBytes": 57862152,
"domNodes": 18,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 121.45999999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.5609999999187,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.823000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.852,
"heapDeltaBytes": 9513100,
"heapUsedBytes": 58156408,
"domNodes": 20,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 128.81400000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1989.678999999967,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.158,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.566,
"heapDeltaBytes": 22988476,
"heapUsedBytes": 71928196,
"domNodes": 18,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 15.012,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.7790000001041,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.136999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.535,
"heapDeltaBytes": 20456880,
"heapUsedBytes": 69600568,
"domNodes": -260,
"jsHeapTotalBytes": 19263488,
"scriptDurationMs": 17.401,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1972.8609999999662,
"styleRecalcs": 84,
"styleRecalcDurationMs": 44.580999999999996,
"layouts": 16,
"layoutDurationMs": 4.558999999999999,
"taskDurationMs": 953.4670000000001,
"heapDeltaBytes": -1247696,
"heapUsedBytes": 47742116,
"domNodes": -262,
"jsHeapTotalBytes": 16117760,
"scriptDurationMs": 94.923,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.8069999999325,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.732,
"layouts": 16,
"layoutDurationMs": 5.126,
"taskDurationMs": 755.2479999999999,
"heapDeltaBytes": 13742056,
"heapUsedBytes": 62777880,
"domNodes": -264,
"jsHeapTotalBytes": 20312064,
"scriptDurationMs": 98.845,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1214.7099999999682,
"styleRecalcs": 16,
"styleRecalcDurationMs": 28.048000000000002,
"layouts": 4,
"layoutDurationMs": 13.194,
"taskDurationMs": 877.1639999999999,
"heapDeltaBytes": 82607044,
"heapUsedBytes": 225472476,
"domNodes": 13513,
"jsHeapTotalBytes": 79691776,
"scriptDurationMs": 35.36599999999999,
"eventListeners": 2527,
"totalBlockingTimeMs": 158,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8203.23099999996,
"styleRecalcs": 250,
"styleRecalcDurationMs": 49.048,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3980.5309999999995,
"heapDeltaBytes": 26278112,
"heapUsedBytes": 83434432,
"domNodes": -262,
"jsHeapTotalBytes": 12292096,
"scriptDurationMs": 1493.585,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8220.953000000009,
"styleRecalcs": 249,
"styleRecalcDurationMs": 54.82,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4292.735000000001,
"heapDeltaBytes": 15564792,
"heapUsedBytes": 74395796,
"domNodes": -263,
"jsHeapTotalBytes": 2854912,
"scriptDurationMs": 1406.7379999999998,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15212.881999999921,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15192.501000000002,
"heapDeltaBytes": 30279212,
"heapUsedBytes": 283380436,
"domNodes": -8329,
"jsHeapTotalBytes": 21819392,
"scriptDurationMs": 724.2950000000001,
"eventListeners": -16487,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12847.42099999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12831.672,
"heapDeltaBytes": -58507124,
"heapUsedBytes": 158421108,
"domNodes": -8331,
"jsHeapTotalBytes": 25227264,
"scriptDurationMs": 634.2430000000002,
"eventListeners": -16465,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14229.192000000012,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.450999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14207.377999999999,
"heapDeltaBytes": 1740548,
"heapUsedBytes": 190548968,
"domNodes": -8331,
"jsHeapTotalBytes": 23044096,
"scriptDurationMs": 869.9769999999999,
"eventListeners": -16460,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14865.453000000001,
"styleRecalcs": 72,
"styleRecalcDurationMs": 19.252999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14844.162999999999,
"heapDeltaBytes": -34536264,
"heapUsedBytes": 164029612,
"domNodes": -8329,
"jsHeapTotalBytes": -3149824,
"scriptDurationMs": 934.5680000000001,
"eventListeners": -16488,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 458.7020000000166,
"styleRecalcs": 20,
"styleRecalcDurationMs": 27.333999999999996,
"layouts": 4,
"layoutDurationMs": 1.3390000000000002,
"taskDurationMs": 141.37500000000003,
"heapDeltaBytes": 5467016,
"heapUsedBytes": 59419536,
"domNodes": 170,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 32.580999999999996,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 460.3069999999434,
"styleRecalcs": 20,
"styleRecalcDurationMs": 26.891,
"layouts": 6,
"layoutDurationMs": 1.367,
"taskDurationMs": 131.6,
"heapDeltaBytes": 5216808,
"heapUsedBytes": 56680380,
"domNodes": 159,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 25.911000000000005,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #12283 +/- ##
===========================================
- Coverage 73.99% 59.63% -14.37%
===========================================
Files 1522 1410 -112
Lines 85209 71970 -13239
Branches 23379 19967 -3412
===========================================
- Hits 63053 42920 -20133
- Misses 21349 28577 +7228
+ Partials 807 473 -334
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1006 files with indirect coverage changes 🚀 New features to boost your workflow:
|
useMediaAssets has been a pass-through to useAssetsApi since the isCloud branch in the same file was removed in the previous commit. Switch the four callers (AssetsSidebarTab, WidgetSelectDropdown, useOutputHistory, useWidgetSelectItems) to use useAssetsApi directly and delete useMediaAssets. useWidgetSelectItems narrows its outputMediaAssets prop type to IAssetsProvider — the same interface useOutputHistory already implements directly — so the function reference is no longer needed as a type source.
dante01yoon
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
dante01yoon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://linear.app/comfyorg/issue/FE-727/refactor-usemediaasset
useMediaAssetswas a factory wrapper that branched onisCloudand returned one of two near-identical implementations (useAssetsApi/useInternalFilesApi). Both implementations delegated to the sameassetsStoreactions (updateInputs/updateHistory/loadMoreHistory) — the real cloud/local fork lives insideassetsStore.fetchInputFiles(line 121), not at the composable layer.Collapse the wrapper:
useInternalFilesApi(identical touseAssetsApi).useMediaAssets(now a pass-through).useAssetsApidirectly.Changes
useInternalFilesApi.tsanduseMediaAssets.ts.AssetsSidebarTab.vue,WidgetSelectDropdown.vue,useOutputHistory.ts: calluseAssetsApidirectly.useWidgetSelectItems.ts: narrowoutputMediaAssetsprop type toIAssetsProvider(the interfaceuseOutputHistoryalready implements directly).useMediaAssets→useAssetsApi.pnpm lint:fixto keep CI green.Review Focus
The real cloud/local fork remains at
assetsStore.ts:121(fetchInputFiles = isCloud ? fetchInputFilesFromCloud : fetchInputFilesFromAPI). That branch is M1-strict and clears once BE-933 lands. This PR only collapses the dead wrapper layer above it.IAssetsProvideris intentionally kept —useOutputHistory.ts:83directly implements it for a different use case, so the interface still has more than one consumer.Surfaced while working on the FE-678 cloud/local asset branching survey.
Screenshots (if applicable)
N/A — no UI change.