fix(website): prevent cloud hero text from overflowing at lg viewports#12293
fix(website): prevent cloud hero text from overflowing at lg viewports#12293Yourz wants to merge 1 commit into
Conversation
The cloud hero text wrapper used lg:translate-x-[25%] which translates by 25% of its own 640px min-width = 160px past the viewport at lg-but-not-xl widths (1024-1279px), making the CLOUD badge, heading, and subtitle clip on portrait monitors like 1080x1920. Sibling product heroes (local, enterprise, api) all use 10% for the same class. Align the cloud hero with that established pattern. Fixes FE-610
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adjusts the responsive horizontal positioning of the hero text container in the cloud product page by reducing its large-screen translate-x offset from 25% to 10%, shifting the text less to the right on larger viewports. ChangesHero Section Responsive Layout
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-12293.vercel.app This commit: https://website-frontend-qgomhx4ju-comfyui.vercel.app Last updated: 2026-05-15T15:20:05Z for |
PR Created by the Glary-Bot Agent
Summary
The cloud hero text wrapper used
lg:translate-x-[25%], which translates by 25% of its ownlg:min-w-160(640px) container — pushing the text 160px past the viewport at the lg-but-not-xl width range (1024–1279px). On portrait monitors like 1080×1920, this clipped theCLOUDbadge, the<h1>heading, and the subtitle.The three sibling product heroes —
local,enterprise,api— all uselg:translate-x-[10%]on the equivalent text wrapper. The25%incloud/HeroSection.vueis the lone outlier. This PR aligns it.Verification
Automated (all on apps/website):
oxlint,eslint,stylelint,oxfmt --check— passpnpm typecheck(astro check) — 0 errors, 0 warningspnpm build— 280 pages built successfullyplaywright test e2e/cloud.spec.ts --project=desktop— 13/13 passplaywright test e2e/visual-responsive.spec.ts --grep "/cloud .* no overflow"— 4/4 pass (393, 768, 1280, 1536)Manual Playwright width-sweep on
/cloudhero: all of 393, 768, 1024, 1080, 1200, 1280, 1366, 1440, 1536, 1600 render with theCLOUDbadge, h1, subtitle, and CTA fully visible.The text container still extends slightly past its parent at lg (same pattern as the canonical enterprise hero, which relies on
html { overflow-x-clip }inBaseLayout.astro), but the visible content — capped bymax-w-mdon the subtitle andlg:max-w-2xlon the h1 — now fits within every viewport tested.Screenshots
┆Issue is synchronized with this Notion page by Unito