Skip to content

fix: RAF-batch canvas ResizeObserver to stop link overlay redraw lag #12300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
christian-byrne wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: RAF-batch canvas ResizeObserver to stop link overlay redraw lag #12300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/scripts/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { useCanvasPositionConversion } from '@/composables/element/useCanvasPosi
import { layoutStore } from '@/renderer/core/layout/store/layoutStore'
import { syncLayoutStoreNodeBoundsFromGraph } from '@/renderer/core/layout/sync/syncLayoutStoreFromGraph'
import { flushScheduledSlotLayoutSync } from '@/renderer/extensions/vueNodes/composables/useSlotElementTracking'
import { createRafBatch } from '@/utils/rafBatch'

import { st, t } from '@/i18n'
import { ChangeTracker } from '@/scripts/changeTracker'
Expand Down Expand Up @@ -949,10 +950,16 @@ export class ComfyApp {

this.rootGraph.start()

// Ensure the canvas fills the window
// Coalesce ResizeObserver bursts during splitter / window drags into one
// resize per frame to stop redundant draw(true, true) calls and the link
// overlay redraw lag they cause.
const scheduleCanvasResize = createRafBatch(() => {
const canvasEl = this.canvasElRef.value
if (canvasEl) this.resizeCanvas(canvasEl)
})
useResizeObserver(this.canvasElRef, ([canvasEl]) => {
if (canvasEl.target instanceof HTMLCanvasElement) {
this.resizeCanvas(canvasEl.target)
scheduleCanvasResize.schedule()
}
})

Expand Down
Loading