Skip to content

[backport cloud/1.44] Subgraph io fixes#12379

Merged
AustinMroz merged 2 commits into
cloud/1.44from
backport-12281-to-cloud-1.44
May 20, 2026
Merged

[backport cloud/1.44] Subgraph io fixes#12379
AustinMroz merged 2 commits into
cloud/1.44from
backport-12281-to-cloud-1.44

Conversation

@comfy-pr-bot
Copy link
Copy Markdown
Member

@comfy-pr-bot comfy-pr-bot commented May 20, 2026

Backport of #12281 to cloud/1.44

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

Fixes 3 different bugs when making links to and from subgraph IO from
vue nodes
- When dragging a link from a node to a subgraph IO, there is no
feedback if a slot is not a valid connection target or if a slot is
actively hovered
- When a link is made from a subgraph IO to a node, the reactivity is
not triggered on the node to indicate a change of link state.
- When dragging a link from a subgraph IO to a node, the link would not
snap to the valid connection targets on nodes
- The fix for this one is not as thorough as I would like. It only
allows connections to the slot, not connections to the hovered widget.
We have two deeply disconnected linking systems and properly reconciling
them would be a multi-week project.

Resolves FE-561

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-12281-Subgraph-io-fixes-3606d73d365081089f7ef19331c6d70a)
by [Unito](https://www.unito.io)
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label May 20, 2026
@comfy-pr-bot comfy-pr-bot mentioned this pull request May 20, 2026
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 20, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

🎭 Playwright: ✅ 1543 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1524 / ❌ 0 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 05/20/2026, 06:03:59 PM UTC

Links

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ons/vueNodes/composables/useSlotLinkInteraction.ts 50.00% 3 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.44   #12379   +/-   ##
=============================================
  Coverage              ?   58.51%           
=============================================
  Files                 ?     1409           
  Lines                 ?    71697           
  Branches              ?    18978           
=============================================
  Hits                  ?    41953           
  Misses                ?    29240           
  Partials              ?      504           
Flag Coverage Δ
unit 58.51% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ons/vueNodes/composables/useSlotLinkInteraction.ts 39.35% <50.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AustinMroz AustinMroz merged commit 694ae7f into cloud/1.44 May 20, 2026
46 checks passed
@AustinMroz AustinMroz deleted the backport-12281-to-cloud-1.44 branch May 20, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants