fix(website): replace favicon.svg with user-supplied design#12381
fix(website): replace favicon.svg with user-supplied design#12381bertfy wants to merge 1 commit into
Conversation
Replace the auto-generated 48x48 dark-mode-aware favicon (introduced in #12285) with a user-supplied 500x500 design. The new design uses the same Comfy C-shape geometry rendered tighter inside a solid black square (no dark-mode color swap). The user supplied the exact SVG. No code changes: BaseLayout.astro still references /favicon.svg, so this is a content-only swap of the file at apps/website/public/favicon.svg.
🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-12381.vercel.app This commit: https://website-frontend-jfg53xemu-comfyui.vercel.app Last updated: 2026-05-20T18:31:15Z for |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Thanks for the approval, @coderabbitai. Noting for the record: there are no inline comments on this PR — the earlier "Review skipped" notice was the default behavior because the only changed file ( For human reviewers: this is a byte-for-byte replacement of the favicon SVG with the file the user attached in Slack. Verification (typecheck / build / |
2 participants
PR Created by the Glary-Bot Agent
Summary
Replaces
apps/website/public/favicon.svgwith the exact SVG provided by the user in Slack (comfy_favicon.svg, 1412 bytes).The previous file (introduced in #12285) was a 48×48 dark-mode-aware version with a
<circle>background. The new file is a 500×500 design supplied by the user: a solid black square with the same Comfy C-glyph rendered tighter (less padding) in#F2FF59yellow, using a mask. No dark-mode color swap.Changes
apps/website/public/favicon.svg— file replaced verbatim with the user-supplied SVG. No code changes needed;apps/website/src/layouts/BaseLayout.astroalready references/favicon.svgwithtype="image/svg+xml".User request
Verification
Built site
pnpm --filter @comfyorg/website typecheck(astro check): 0 errors, 0 warnings, 2 pre-existing hints unrelated to this changepnpm --filter @comfyorg/website build(astro build): 279 pages built, exit 0pnpm --filter @comfyorg/website test:unit: 11 files, 77 tests, all passdist/index.htmlhead contains exactly one<link rel="icon" href="/favicon.svg" type="image/svg+xml">, and/favicon.svgis the only favicon URL referenced anywhere indist/.md5(dist/favicon.svg) == md5(public/favicon.svg)after the build.Visual
dist/over local HTTP in a headless browser and inspecteddocument.querySelector('link[rel="icon"]')→ confirmedhref="/favicon.svg",type="image/svg+xml", no other icon links.One note for the reviewer
The new design intentionally has tighter padding than the previous version. At 32 px and up the C-glyph is clearly recognizable; at the native 16 px tab size it reads as a more zoomed-in yellow mark on a black square (vs. the previous, slightly more circular-badge-y look). Both ship a black background so contrast vs. the original transparent yellow is the main legibility win in both cases. Flagging in case anyone wants to tweak the inner scale — this PR ships exactly the file the user supplied.
Related context (not blocking)
The production site at
https://comfy.org/favicon.svgis currently still serving the default Astro starter favicon (the angular black "rocket" path that was the basis of the original "weird upside-down V" report), even though #12285 merged tomainon May 18. This PR will overwrite that on next deploy, but ifmaindeploys haven't been picking up, it's worth checking the Vercelwebsite-frontend-comfyuiproject before relying on this PR alone to fix what the user saw in their screenshot.Screenshots
Side-by-side: previous (top) vs new (bottom) at 16 / 32 / 48 / 128 px, plus tab strip and Google search row
New favicon previewed standalone at native sizes
Screenshots
┆Issue is synchronized with this Notion page by Unito