fix: preserve selected filter values state with reactive Set ref#3583
Closed
orzyyyy wants to merge 4 commits intoComfy-Org:mainfrom
Closed
fix: preserve selected filter values state with reactive Set ref#3583orzyyyy wants to merge 4 commits intoComfy-Org:mainfrom
orzyyyy wants to merge 4 commits intoComfy-Org:mainfrom
Conversation
webfiltered
suggested changes
Apr 23, 2025
Contributor
webfiltered
left a comment
There was a problem hiding this comment.
Once added, filters can never be removed from the existing filters set (so add, remove, add again will fail silently).
Would be good to rename it to existingFilters.
Author
|
However, when I click the remove icon, the filter is properly removed. My operation steps were: add, remove, then add again. I'm not sure if this kind of error handling is required in this scenario. |
webfiltered
suggested changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #3559
┆Issue is synchronized with this Notion page by Unito