PWA support #3639
Merged
PWA support #3639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-byrne
requested changes
Apr 26, 2025
huchenlei
approved these changes
Apr 29, 2025
huchenlei
suggested changes
Apr 29, 2025
There was a problem hiding this comment.
Please fix build error:
error during build:
[vite:build-html] Unable to parse HTML; parse5 error code missing-whitespace-between-attributes
at /home/runner/work/ComfyUI_frontend/ComfyUI_frontend/ComfyUI_frontend/index.html:17:16
15 | <meta name="viewport" content="width=device-width, initial-scale=1, viewpor>
16 |
17 | <link rel="manifest" href="manifest.json">
| ^
18 |
19 | </head>
file: /home/runner/work/ComfyUI_frontend/ComfyUI_frontend/ComfyUI_frontend/index.html
at handleParseError (file:///home/runner/work/ComfyUI_frontend/ComfyUI_frontend/ComfyUI_frontend/node_modules/vite/dist/node/chunks/dep-DbT5NFX0.js:35172:9)
at Parser.onParseError (file:///home/runner/work/ComfyUI_frontend/ComfyUI_frontend/ComfyUI_frontend/node_modules/vite/dist/node/chunks/dep-DbT5NFX0.js:35097:7)
at Tokenizer._err (file:///home/runner/work/ComfyUI_frontend/ComfyUI_frontend/ComfyUI_frontend/node_modules/vite/dist/node/chunks/dep-D-7KCb9p.js:1155:89)
at Tokenizer._stateAfterAttributeValueQuoted (file:///home/runner/work/ComfyUI_frontend/ComfyUI_frontend/ComfyUI_frontend/node_modules/vite/dist/node/chunks/dep-D-7KCb9p.js:2760:22)
at Tokenizer._callState (file:///home/runner/work/ComfyUI_frontend/ComfyUI_frontend/ComfyUI_frontend/node_modules/vite/dist/node/chunks/dep-D-7KCb9p.js:1666:22)
at Tokenizer._runParsingLoop (file:///home/runner/work/ComfyUI_frontend/ComfyUI_frontend/ComfyUI_frontend/node_modules/vite/dist/node/chunks/dep-D-7KCb9p.js:1179:22)
at Tokenizer.write (file:///home/runner/work/ComfyUI_frontend/ComfyUI_frontend/ComfyUI_frontend/node_modules/vite/dist/node/chunks/dep-D-7KCb9p.js:1204:14)
at Parser.parse (file:///home/runner/work/ComfyUI_frontend/ComfyUI_frontend/ComfyUI_frontend/node_modules/vite/dist/node/chunks/dep-D-7KCb9p.js:[48](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/14725970382/job/41359210690?pr=3639#step:6:49)86:26)
at parse (file:///home/runner/work/ComfyUI_frontend/ComfyUI_frontend/ComfyUI_frontend/node_modules/vite/dist/node/chunks/dep-D-7KCb9p.js:7957:19)
at traverseHtml (file:///home/runner/work/ComfyUI_frontend/ComfyUI_frontend/ComfyUI_frontend/node_modules/vite/dist/node/chunks/dep-DbT5NFX0.js:35092:15)
Error: Process completed with exit code 1.
|
For context:
|
christian-byrne
approved these changes
May 20, 2025
christian-byrne
approved these changes
May 20, 2025
christian-byrne
added a commit
that referenced
this pull request
May 22, 2025
Co-authored-by: bymyself <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change, but I would appreciate PWA support for iOS devices, so when added to home screen it looks better.
┆Issue is synchronized with this Notion page by Unito