Skip to content

Set link release (no modifier) default to search box #3652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Apr 26, 2025

Currently, when releasing link on canvas, the default action is to open the context menu. However, the Litegraph context menus are too difficult to navigate, and the suggestions are misleading about what nodes are actually compatible with the dropped link. The search box has fuzzy searching, filters, a more modern UI, and allows for quicker usage and feedback.

A new user should not be subjected to the context menus as the default link release experience.

@christian-byrne christian-byrne requested a review from a team as a code owner April 26, 2025 21:29
Copy link
Contributor

@webfiltered webfiltered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend swapping the two actions, rather than of making both shift and .. shiftless? open search.

N.B. This will also impact anyone who hasn't set the value explicitly. It might be a good idea to add some check so as not to impact existing users who just had the default and liked it.

@christian-byrne
Copy link
Contributor Author

christian-byrne commented May 20, 2025

I think we should be decisive about these types of design decisions and be okay switching users who have not set a value in the past to the new search box on link release. The new search is a far better experience then the nested LG context menus and also it's something we actually plan on supporting and extending. Perhaps I should seek some other opinions though, because that is jusy my 2 cents. I'll report back after gathering some opinions.

@webfiltered
Copy link
Contributor

First part: Only one of the two settings has been changed. It means that dragging a link with shift held does exactly the same thing as not holding shift (effectively disabling that feature). Is that intended?

Second part: I strongly agree the default should be search, despite its current issues (e.g. search lists every "ANY" node first, so it seems a lot of folks use the context menu "quick" list).

I was just flagging that in case it had not been considered, moreso than taking a stance -- the PR said "new user should", and didn't mention any impact to existing users. I figured we should only change this for new users, rather than silently update existing users.

"What's new" system would make this much easier.

@christian-byrne
Copy link
Contributor Author

First part: Only one of the two settings has been changed. It means that dragging a link with shift held does exactly the same thing as not holding shift (effectively disabling that feature). Is that intended?

Oh, sorry: I somehow failed to register that aspect of your initial comment. You're right, I should swap them.

@github-actions github-actions bot requested review from Yorha4D, KarryCharon, shinshin86 and a team as code owners May 20, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants