[Feature] Add "All" category to template workflows #3931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-byrne
force-pushed
the
template-all-category
branch
2 times, most recently
from
0a5c424 to
af71601
Compare
christian-byrne
force-pushed
the
template-all-category
branch
from
b27f751 to
2a84c6a
Compare
christian-byrne
force-pushed
the
template-all-category
branch
from
2a84c6a to
6242dd8
Compare
|
The two failing tests are from the default category now being "All" rather than "Basics"
|
christian-byrne
requested review from
Yorha4D,
KarryCharon,
shinshin86 and
a team
as code owners
christian-byrne
added
the
New Browser Test Expectations
|
Would like to merge this. Note:
Any objection @webfiltered? |
webfiltered
requested changes
Jun 4, 2025
…- addresses @webfiltered's performance suggestions Convert repeated function calls for template title and description to computed properties in TemplateWorkflowList.vue to avoid redundant computations during rendering.
…addresses @webfiltered's API cleanup suggestion Remove fetchTemplateJson from useTemplateWorkflows exports since it's only used internally within the composable. Update corresponding test mocks.
webfiltered
approved these changes
Jun 4, 2025
lordTyrion
pushed a commit
to playbook3d/ComfyUI_frontend
that referenced
this pull request
Jul 2, 2025
Co-authored-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "All" category to template workflows and refactors the template management into a dedicated composable. This PR improves workflow template organization by providing a centralized way to browse all available templates regardless of source, supported by proper test coverage.
Changes to data structure will also make it easier to add a search feature.
┆Issue is synchronized with this Notion page by Unito