[feature] Add text and PDF file upload support #3947
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-byrne
force-pushed
the
feature/text-upload-support
branch
from
94a2aa2 to
eca9e3d
Compare
christian-byrne
force-pushed
the
feature/text-upload-support
branch
from
3bdcb68 to
53ccd4a
Compare
christian-byrne
commented
May 29, 2025
christian-byrne
requested review from
Yorha4D,
KarryCharon,
shinshin86 and
a team
as code owners
webfiltered
requested changes
May 30, 2025
Adds allow_batch configuration support to text upload widgets, enabling multiple file uploads when specified. Changes include: - Support for allow_batch input specification - Batch file processing with uploadTextFiles function - Value transform logic for single vs array outputs - Dynamic button text (file/files) based on batch mode - Translation keys for plural file selection
Co-authored-by: filtered <[email protected]>
- Use proper discriminated unions instead of manual type checking - Replace 'any' types with 'unknown' for better type safety - Update naming: TEXTUPLOAD → TEXT_FILE_UPLOAD, text_upload → text_file_upload - Extract constants for maintainability (SUPPORTED_FILE_TYPES, TEXT_FILE_UPLOAD) - Convert to V2 widget pattern with ComfyWidgetConstructorV2 - Self-documenting function names replacing comments - Clean error handling with proper type guards Addresses all PR review feedback for improved code quality and consistency.
christian-byrne
force-pushed
the
feature/text-upload-support
branch
from
648e17f to
1989561
Compare
|
It might be better to generalize this process. That is, we make an API whereby nodes can declare they want to support upload connected to a specific COMBO widget, while also specifying the mimetype and fileextension list (same format as the Otherwise, we will be adding all this boiler plate for each new input file type, which will be harder to propogate bug fixes across. |
|
Replace this PR with #4071 after it has been implemented. |
|
Will be redone in Vue Nodes more easily, no longer necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for text file uploads in ComfyUI nodes, similar to how image and video uploads are handled. This allows for text files (including PDFs) to be uploaded via a button, drag-and-drop, or clipboard paste.\n\nNodes can use the new 'text_upload: true' flag on combo inputs to enable this functionality.
┆Issue is synchronized with this Notion page by Unito