Skip to content

fix: add beforeChange/afterChange to convertToSubgraph for proper undo #7791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
godwiniheuwa wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: add beforeChange/afterChange to convertToSubgraph for proper undo #7791

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
66f0d01
fix: add beforeChange/afterChange to convertToSubgraph for proper undo
RUiNtheExtinct Dec 28, 2025
55d4d62
fix(LGraph): wrap convertToSubgraph mutations in try-finally
RUiNtheExtinct Dec 28, 2025
008b1db
fix(LGraph): wrap unpackSubgraph mutations in try-finally for consist…
RUiNtheExtinct Dec 28, 2025
6e2a65f
Merge branch 'main' into fix/subgraph-conversion-undo
godwiniheuwa Dec 31, 2025
9cdc9b4
Merge branch 'main' into fix/subgraph-conversion-undo
godwiniheuwa Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 32 additions & 2 deletions src/lib/litegraph/src/LGraph.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1509,6 +1509,22 @@ export class LGraph
} {
if (items.size === 0)
throw new Error('Cannot convert to subgraph: nothing to convert')

// Record state before conversion for proper undo support
this.beforeChange()

try {
return this._convertToSubgraphImpl(items)
} finally {
// Mark state change complete for proper undo support
this.afterChange()
}
}

private _convertToSubgraphImpl(items: Set<Positionable>): {
subgraph: Subgraph
node: SubgraphNode
} {
const { state, revision, config } = this
const firstChild = [...items][0]
if (items.size === 1 && firstChild instanceof LGraphGroup) {
Expand Down Expand Up @@ -1715,6 +1731,7 @@ export class LGraph

subgraphNode._setConcreteSlots()
subgraphNode.arrange()

this.canvasAction((c) =>
c.canvas.dispatchEvent(
new CustomEvent('subgraph-converted', {
Expand All @@ -1733,9 +1750,23 @@ export class LGraph
if (!(subgraphNode instanceof SubgraphNode))
throw new Error('Can only unpack Subgraph Nodes')

// Record state before unpacking for proper undo support
this.beforeChange()

try {
this._unpackSubgraphImpl(subgraphNode, options)
} finally {
// Mark state change complete for proper undo support
this.afterChange()
}
}

private _unpackSubgraphImpl(
subgraphNode: SubgraphNode,
options?: { skipMissingNodes?: boolean }
) {
const skipMissingNodes = options?.skipMissingNodes ?? false

this.beforeChange()
//NOTE: Create bounds can not be called on positionables directly as the subgraph is not being displayed and boundingRect is not initialized.
//NOTE: NODE_TITLE_HEIGHT is explicitly excluded here
const positionables = [
Expand Down Expand Up @@ -2006,7 +2037,6 @@ export class LGraph
}

this.canvasAction((c) => c.selectItems(toSelect))
this.afterChange()
}

/**
Expand Down