Skip to content

Fix CLIPMergeSimple ratio documentation (fixes #918)#979

Merged
comfyui-wiki merged 1 commit into
Comfy-Org:mainfrom
lin-bot23:fix-clip-merge-simple-ratio
May 11, 2026
Merged

Fix CLIPMergeSimple ratio documentation (fixes #918)#979
comfyui-wiki merged 1 commit into
Comfy-Org:mainfrom
lin-bot23:fix-clip-merge-simple-ratio

Conversation

@lin-bot23
Copy link
Copy Markdown
Contributor

Fixes #918

Problem

The CLIPMergeSimple documentation described the ratio parameter backwards:

  • It claimed ratio = 0.0 = 100% clip1 and ratio = 1.0 = 100% clip2
  • The actual code does m.add_patches({k: kp[k]}, 1.0 - ratio, ratio), which means:
    • ratio = 1.0 → patch strength = 0, model strength = 1.0 → 100% clip1
    • ratio = 0.0 → patch strength = 1.0, model strength = 0 → 100% clip2

This matches ModelMergeSimple behavior exactly (which already had correct docs).

Changes

  • English: Corrected the ratio input description and the "Ratio Parameter Explained" section
  • 简体中文: Same corrections in Chinese
  • 日本語: Same corrections in Japanese

Verification

# Both CLIPMergeSimple and ModelMergeSimple use the same merge pattern:
m = model1.clone()
kp = model2.get_key_patches()
for k in kp:
    m.add_patches({k: kp[k]}, 1.0 - ratio, ratio)
# ratio = 1.0 → 100% model1, ratio = 0.0 → 100% model2

… clip2

The ratio parameter works the same as ModelMergeSimple's ratio — when
ratio=1.0 the output is 100% clip1, and when ratio=0.0 the output is
100% clip2. The docs previously described it backwards.

Fixes Comfy-Org#918
@lin-bot23 lin-bot23 force-pushed the fix-clip-merge-simple-ratio branch from aa8a940 to ebdd11f Compare May 11, 2026 10:13
@comfyui-wiki comfyui-wiki merged commit c1b771b into Comfy-Org:main May 11, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue on docs - CLIPMergeSimple: ratio is described wrong

2 participants