Skip to content

&expected_relay_pubkey #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sambacha
Copy link

check against the static pubkey, not the pubkey in the message

@ltitanb
Copy link
Collaborator

ltitanb commented Jul 24, 2025

any reason for this? we check just above that the two keys are the same?
https://github.com/Commit-Boost/commit-boost-client/blob/main/crates/pbs/src/mev_boost/get_header.rs#L464-L469

@sambacha
Copy link
Author

sambacha commented Jul 24, 2025

any reason for this? we check just above that the two keys are the same? main/crates/pbs/src/mev_boost/get_header.rs#L464-L469

expected is the relay url pubkey, the received key could be a different key and still pass signature check. Verifying the signature using the provided pubkey itself doesn't actually provide any benefit: it will always return valid. Hence why the pubkey is stored in the relay's url, this provides the pubkey to use for validity check.

Yes your correct.

Also I thought pub key was suppose to be the last part of the message or maybe I am misremembering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants