Refactor system bar visibility handling on Android

[ne0rrmatrix]

• Bug fix

Description of Change

Modernized the handling of system bar visibility in the MauiMediaElement class by replacing the legacy SetSystemBarsVisibility method with a new SetStatusBarsHidden method. This leverages modern Android APIs (WindowManagerFlags and WindowInsetsControllerCompat) for better compatibility and maintainability.

Introduced static properties (window, decorView, insetsController) to encapsulate window-related logic with improved error handling. Removed legacy code for Android versions below API 30, simplifying the codebase.

Updated fullscreen handling logic to align with modern Android development practices. Improved layout invalidation on fullscreen button clicks and ensured consistent system bar visibility management across the codebase.

Enhanced code readability, maintainability, and robustness by reducing duplication, leveraging modern APIs, and improving error handling.

Has legacy support from android 26 and is tested against 26, 33,34, and 35 with both button and gesture navigation.

Linked Issues

• Fixes [BUG] TabBar position is changed after MediaElement exits fullscreen mode on Android #2893

PR Checklist

• Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
• Has tests (if omitted, state reason in description)
• Has samples (if omitted, state reason in description)
• Rebased on top of main at time of PR
• Changes adhere to coding standard
• Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

Tested against android 26, 33, 34, and 35. I tested against gesture navigation and 3 button navigation on each platform with media element sample app page. It fixes the issue raised where tab bar size is incorrect upon leaving full screen mode.

[Copilot]

Pull Request Overview

This PR refactors the system bar visibility handling in the MauiMediaElement Android class by replacing legacy APIs with modern Android approaches. The change improves maintainability and compatibility while fixing issues with tab bar sizing after exiting fullscreen mode.

Key Changes:

• Replaced legacy SetSystemBarsVisibility method with SetStatusBarsHidden using modern Android APIs
• Introduced static properties for better window-related logic encapsulation
• Removed support for Android versions below API 26, simplifying the codebase

[Copilot]

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.

[Copilot]

The method SetStatusBarsHidden is marked as public static, but it should be private or internal since it's an implementation detail of system bar visibility management. Making it public exposes internal Android-specific behavior that shouldn't be part of the public API surface. Consider changing the visibility to private or internal.

Suggested change

	public static void SetStatusBarsHidden(bool hidden)
	static void SetStatusBarsHidden(bool hidden)

[Copilot]

The version check OperatingSystem.IsAndroidVersionAtLeast(26) wraps all the logic, but the PR description states the code supports Android API 26+. If this is the minimum supported Android version for the entire library, this check is redundant since the code inside would always execute. If API 26 is not the minimum, consider what behavior should occur when running on versions below API 26 - currently, the method would silently do nothing, which could leave the app in an inconsistent state.

[Copilot]

The removal of WindowCompat.SetDecorFitsSystemWindows may cause layout issues. The previous implementation correctly managed whether the window content should fit within the system windows (status bar, navigation bar). Without this call:

• In fullscreen mode, content may not properly extend behind system bars
• When exiting fullscreen, the layout may not properly account for system bar insets

Other parts of the codebase (e.g., StatusBar.android.cs) still use WindowCompat.SetDecorFitsSystemWindows(window, true/false) to manage this behavior. Consider adding back:

if (hidden)
{
    WindowCompat.SetDecorFitsSystemWindows(window, false);
    // ... existing code
}
else
{
    // ... existing code
    WindowCompat.SetDecorFitsSystemWindows(window, true);
}

[Copilot]

Variables window, decorView, and insetsController are declared with explicit types instead of using var. According to the .NET Foundation coding style guidelines followed by this project, local variables should use var when the type is obvious from the right-hand side. Consider changing to:

var window = Platform.CurrentActivity?.Window ?? throw new InvalidOperationException("Current activity is null");
var decorView = window.DecorView ?? throw new InvalidOperationException("DecorView is null");
var insetsController = WindowCompat.GetInsetsController(window, decorView) ?? throw new InvalidOperationException("InsetsController is null");

Suggested change

	Window window = Platform.CurrentActivity?.Window ?? throw new InvalidOperationException("Current activity is null");
	View decorView = window.DecorView ?? throw new InvalidOperationException("DecorView is null");
	AndroidX.Core.View.WindowInsetsControllerCompat insetsController = WindowCompat.GetInsetsController(window, decorView) ?? throw new InvalidOperationException("InsetsController is null");
	var window = Platform.CurrentActivity?.Window ?? throw new InvalidOperationException("Current activity is null");
	var decorView = window.DecorView ?? throw new InvalidOperationException("DecorView is null");
	var insetsController = WindowCompat.GetInsetsController(window, decorView) ?? throw new InvalidOperationException("InsetsController is null");

[Copilot]

The new implementation creates window/decorView/insetsController variables on every call to SetStatusBarsHidden, which is inefficient compared to the previous approach that cached these references. Since this method is called from OnVisibilityChanged (which can be triggered frequently) and OnFullscreenButtonClick, consider caching these references to avoid repeated lookups and object creation on each call.

[Copilot]

The new SetStatusBarsHidden method lacks XML documentation comments. According to the coding guidelines, public methods should have XML documentation. Since this method is currently public (though it should likely be private/internal), add documentation explaining:

• The purpose of the method
• The hidden parameter
• Any exceptions that may be thrown

Example:

/// <summary>
/// Sets the visibility of system bars (status bar and navigation bar).
/// </summary>
/// <param name="hidden">If <see langword="true"/>, hides the system bars; otherwise, shows them.</param>
/// <exception cref="InvalidOperationException">Thrown when the current activity, DecorView, or InsetsController is null.</exception>

Suggested change

	/// <summary>
	/// Sets the visibility of system bars (status bar and navigation bar).
	/// </summary>
	/// <param name="hidden">If <see langword="true"/>, hides the system bars; otherwise, shows them.</param>
	/// <exception cref="InvalidOperationException">Thrown when the current activity, DecorView, or InsetsController is null.</exception>

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[Copilot]

The API version check for Android 26 is redundant since the project's SupportedOSPlatformVersion for Android is already set to 26.0 in the .csproj file. This means the app cannot run on Android versions below API 26, so the runtime check adds no value and should be removed. Simply execute the code in the if (hidden) and else blocks directly without the version check wrapper.