Skip to content

Support nested blocks in semi-auto property analyzer, add tests #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2025
Merged

Support nested blocks in semi-auto property analyzer, add tests #1025

merged 2 commits into from
Nov 25, 2025

Conversation

@Youssef1313
Copy link
Contributor

@Youssef1313 Youssef1313 commented Dec 12, 2024 •
edited by Sergio0694
Loading

Title.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 changed the title More tests for semi auto prop analyzer Support nested blocks in semi-auto property analyzer, add tests Nov 24, 2025
Youssef1313 and others added 2 commits November 24, 2025 15:39
@Youssef1313 @Sergio0694
More tests for semi auto prop analyzer
e635084
@Sergio0694
Handle nested block operations in analyzer
b3c0266 
Adds support for analyzing nested block operations in 'get' accessors, improving compatibility with code generated by other tooling. The analyzer now correctly identifies return operations within nested blocks.
Sergio0694
Sergio0694 approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😄

@Sergio0694 Sergio0694 merged commit 52aec6f into CommunityToolkit:main Nov 25, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sergio0694 Sergio0694 Sergio0694 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Youssef1313 @Sergio0694